Skip to content

*flush-on-newline* support #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Feb 9, 2024

Hi,

could you please consider patch to support the Clojure's *flush-on-newlne* dynamic var. It fixes #865.

Although the corresponding documentation string in Clojure describes this variable as used for flushing the stream everytime a newline is printed, it is only referenced by prn to flush its output after the last newline has been written. This patch follows the same logic.

Thanks

@ikappaki ikappaki force-pushed the feat/flush-on-newline branch from 325c01f to 9a27d04 Compare February 9, 2024 20:44
@ikappaki
Copy link
Contributor Author

ikappaki commented Feb 9, 2024

In Clojure, println is based on prn, so I've also modified println to observer the dynamic variable.

@ikappaki ikappaki force-pushed the feat/flush-on-newline branch from 9a27d04 to ea07521 Compare February 10, 2024 21:05
@chrisrink10 chrisrink10 merged commit 144dc24 into basilisp-lang:main Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*flush-on-newline* support
2 participants