Make support for single-use iterables explicit #1235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
could you please consider patch to remove explicit support of single-use iterables in sequences. It fixes #1192.
single-use iterables now throw a
TypeError
, when they are implicitly or explicitly coerced into a sequence. A newiterator-seq
is introduced to explicitly convert them into a seq instead . See #1198 (comment) for the rationale.The
count
fn was also updated to behave the same.There were a few places where single use iterators were converted implicitly to a seq, which are now explicitly converted using a
iterator-seq
or the python equivalent instead.Tests are added for the same, as well as documentation section under Python Iterators.
Thanks