inconsistent keywordization of strings containing slashes

[ikappaki]

Hi,

there appears to be an issue when trying to keywordizing strings containing slashes, such as "abc/xyz". These string don't compare equal to their corresponding namespaced keywords, even though their string representation match.

To reproduce

• Open up the REPL, create a keywordize slashed string, compare it with its counterpart and inspect it, it fails the check

basilisp.user=> (def issuekw (keyword "abc/xyz"))
#'basilisp.user/issuekw

basilisp.user=> issuekw
:abc/xyz

basilisp.user=> (= issuekw :abc/xyz)
false

basilisp.user=> (namespace issuekw)
nil

basilisp.user=> (name issuekw)
"abc/xyz"

In clojure comparison works as expected, comparing equal with their counterparts, internally the string to a namespace and name components

user=> (def issuekw (keyword "abc/xyz"))
#'user/issuekw
user=>  issuekw
:abc/xyz
user=> (= issuekw :abc/xyz)
true
user=> (namespace issuekw)
"abc"
user=> (name issuekw)
"xyz"

Thanks

[chrisrink10]

😓 This is completely undocumented behavior on the part of Clojure and really seems like something they shouldn't allow. The fix is straightforward enough though.

I'll just also note that the way it works in Clojure still can have some surprising results:

((juxt namespace name) (keyword "abc/def/xyz"))  ;;=> ["abc" "def/xyz"]

[ikappaki]

Thanks for the fix!

😓 This is completely undocumented behavior on the part of Clojure and really seems like something they shouldn't allow. The fix is straightforward enough though.

I'll just also note that the way it works in Clojure still can have some surprising results:

((juxt namespace name) (keyword "abc/def/xyz"))  ;;=> ["abc" "def/xyz"]

Indeed. IMO it gets even stranger because it allows any illegal character to be part of the keyword name, which I think it does break reading the form back completely (example below is in Clojure)

user=> (keyword "^#{[abc")
:^#{[abc
user=> (keyword "")
: