Repository navigation
fix: fastmcp deprecation warning - #150
Merged
Merged
Conversation
groksrc
changed the title
- Remove log_level from FastMCP constructor in server.py - Add log_level='DEBUG' to mcp_server.run() calls in mcp.py - Fixes deprecation warning that appeared when running 'bm --version' - Follows fastmcp recommendation to provide log_level when calling run() Signed-off-by: Drew Cain <groksrc@gmail.com>
groksrc
force-pushed
the
fix-fastmcp-deprecation-warning
branch
from
June 19, 2025 19:30
fd44d65 to
3dc8a8f
Compare
phernandez
reviewed
Jun 20, 2025
phernandez
reviewed
Jun 20, 2025
Signed-off-by: Paul Hernandez <60959+phernandez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bm --versionorbasic-memory --versionlog_levelparameter from FastMCP constructor to therun()method as recommended by fastmcpChanges
log_level="DEBUG"from FastMCP constructor inserver.pylog_level="DEBUG"to bothmcp_server.run()calls inmcp.pyTest
After this change, running
bm --versionno longer shows the deprecation warning:Context
This warning was discovered after installing basic-memory v0.13.7 via Homebrew.