Skip to content

CLI output drops or crashes on bracketed values; duplicate deprecation line; insert_after_section blank line #1720

Description

@phernandez

Found during the v0.24.0 acceptance test.

  1. About 59 console.print(f"[style]...{value}...[/style]") calls in src/basic_memory/cli put user values (project names, paths, exception text) directly into Rich markup. Bracketed text is dropped (proj [x] prints as proj ), a value with a closing tag such as a[/b]c raises MarkupError and crashes the command, and [bold] restyles the output. Escape the values with rich.markup.escape, or print them with markup=False, as feat(cli): deprecate cloud bisync and mirror sync; diagnostics env overrides #1711 did for the mirror notices.
  2. The deprecated bm cloud sync, bisync and bisync-reset print Typer's own DeprecationWarning: The command 'sync' is deprecated. line above our notice, so the warning appears twice. Keep the (deprecated) mark in help and drop the duplicate runtime line.
  3. edit_note insert_after_section leaves a blank line between the inserted content and the section's existing first line, which splits a list in two.

Activity

  1. added this to the v0.24.x milestone on Oct 10, 2026
  2. claude commented on Oct 10, 2026

    @claude
    Contributor

    Claude finished @phernandez's task in 16s —— View job


    Triage

    Notes for whoever picks this up:

    • Item 1 needs a regression test with a bracketed project name and a value containing a closing tag.
    • Item 3 needs a test that inserting before a list item keeps the list contiguous.
    • Per the repo's coverage rule, new code needs tests.

    I have only triaged this. I made no code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions