Added support for IsNotNull & IsNull filters #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srgg
reviewed
Jan 10, 2017
| } | ||
|
|
||
| protected def whereClause(filters: Array[Filter]): (String, Seq[Any]) = { | ||
| val sqlValue = filters.map(filterToSqlAndValue) | ||
| val sql = sqlValue.map(_._1).mkString(" AND ") | ||
| val args = sqlValue.map(_._2) | ||
| val args = sqlValue.flatMap(_._2) |
There was a problem hiding this comment.
There should be a comment that explains why we are using flatMap
AleksandrPavlenko
force-pushed
the
fix-null-constrains
branch
5 times, most recently
from
02323e2 to
7943cf8
Compare
AleksandrPavlenko
force-pushed
the
fix-null-constrains
branch
from
7943cf8 to
dd74295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for IsNotNull & isNull spark sql filters. It breaks compatibility with Riak TS versions older than 1.5.