Remove lager parse transform #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a code hygiene issue for you, or were you trying to use eleveldb in a project without lager? |
|
I'm not sure I'd use the term code hygiene here. It's unclean to have a parse transform applied from something that isn't an explicit dependency IMO, and yes, I'm using eleveldb in an environment where we are not using cuttlefish and thus doesn't fetch the implicit lager dependency (which works just fine as well). There's no calls to lager:* inside of eleveldb itself. |
|
Yea, it is just not right, so why keep it? |
|
Agreed. |
jonmeredith
pushed a commit
that referenced
this pull request
Jul 9, 2015
Remove lager parse transform
jonmeredith
pushed a commit
that referenced
this pull request
Jul 9, 2015
Remove lager parse transform
jonmeredith
pushed a commit
that referenced
this pull request
Jul 9, 2015
Remove lager parse transform
|
Applied to 2.0 and 2.1 branches too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst debugging something where I disabled the cuttlefish dependency, I noticed that lager applied the lager parse transform without actually using lager anywhere. This patch removes the
lager_transformfromerl_opts.