Install shellcheck and shfmt for deploy workflow #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of the release scripts call `pnpm verify:bail` (which runs the test suite), so these test dependencies need to be installed here as well. Although `shellcheck` is included in GitHub's `ubuntu-latest` build image, we explicitly install it here both for consistency with the `verify` workflow and as a guard against this being removed from the build image in future.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 29 29
Lines 1409 1409
Branches 334 334
=======================================
Hits 1144 1144
Misses 218 218
Partials 47 47 ☔ View full report in Codecov by Sentry. |
|
Thanks for fixing! |
|
@skovhus Don't know if you've noticed - the deploy is still failing, but this time because your access token has expired. Can't help with that one. :-) |
|
Latest version I can install is 5.2.0, NPM needs sorting: https://www.npmjs.com/package/bash-language-server?activeTab=versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge of my
shfmtchanges broke thedeployworkflow. Both of the release scripts callpnpm verify:bail(which runs the test suite), so these test dependencies need to be installed here as well.Although
shellcheckis included in GitHub'subuntu-latestbuild image, we explicitly install it here both for consistency with theverifyworkflow and as a guard against this being removed from the build image in future.