Update truss push semantics for clearer mental model.
#2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment
- Change truss push default behavior to create published deployments
- Add --watch flag for explicit development deployment creation
- Update chains push to default to published deployments
- Add proper validation for conflicting flags
- Update error messages to reference --watch flag
- Add comprehensive tests for new behavior
This ensures consistent behavior across truss and chains:
- truss push -> published deployment
- truss push --watch -> development deployment
- truss push --environment {env} -> deployment with environment promotion
- truss chains push -> published deployment (default)
- truss chains push --watch -> development deployment
Resolves inconsistencies in deployment semantics between truss and chains.
- Update --watch flag to automatically stream deployment logs like --tail - After log streaming completes, automatically start live patching mode - Add helpful user messages explaining the watch functionality - Add test coverage for the new --watch log streaming behavior - Update help text to document the log streaming feature This makes --watch a complete development experience: 1. Creates development deployment 2. Streams deployment logs in real-time 3. Automatically starts live patching mode 4. Provides clear feedback to user throughout the process
- Add spec.config.model_metadata tags to all mock truss objects - Add uses_trt_llm_builder mock to watch test to avoid TRT-LLM restriction - Fix test indentation and structure issues
- Fix test indentation and structure issues - Remove fragile log watcher assertion that depends on implementation details - Ensure all tests pass with proper mocking - All 6 tests now pass successfully
- Mark --promote flag as [DEPRECATED] in help text for both truss and chains
- Add deprecation warning when --promote flag is used
- Update help text to guide users to --environment production or --environment {env_name}
- Update error messages to reference --environment instead of --promote
- Update documentation strings in API to reflect deprecation
- Add test to verify deprecation warning behavior
- Update all related help text (deployment-name, preserve-previous-production-deployment)
This encourages the more explicit and flexible environment-based deployment approach:
- Use --environment production instead of --promote
- Use --environment {env_name} for any specific environment
- Maintains backward compatibility with clear deprecation warnings
- Mark --publish flag as [DEPRECATED] in help text for both truss and chains
- Add deprecation warning when --publish flag is explicitly used
- Update help text to clarify that published deployments are now the default
- Guide users to use --watch for development deployments instead
- Update error messages to reflect that default is published
- Update API documentation to mark publish parameter as deprecated
- Add test to verify --publish deprecation warning behavior
- Mention flag will be removed in the following release
This streamlines the CLI experience:
- Default: truss push (published deployment)
- Development: truss push --watch
- Environment: truss push --environment {env_name}
- Both --publish and --promote are deprecated but still functional
- Comprehensive documentation of consistent behavior across both commands - Behavior matrix showing all deployment options and their status - Migration path guidance for users - Test coverage summary and validation results - Benefits of the new consistent approach This serves as a reference for the new unified deployment semantics across the entire truss ecosystem.
- Fix trailing whitespace issues - Fix end-of-file formatting - Apply ruff formatting to code
- Remove temporary .cursor directory that was created during development - Clean up repository to only include necessary files
- Remove temporary documentation file that was created during development - Clean up repository to only include necessary files
dsingal0
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Overview
This PR fundamentally changes the deployment semantics for both truss push and truss chains push to create published deployments by default, with a new --watch flag for explicit
development deployments. This ensures consistent behavior across the entire truss ecosystem while providing enhanced development experience with automatic log streaming and live
patching.
🎯 Key Changes
1. New Default Behavior
• truss push (no flags) → Creates published deployment (was development)
• truss chains push (no flags) → Creates published deployment (was development)
• truss push --watch → Creates development deployment with hot reload + log streaming
• truss chains push --watch → Creates development deployment with live patching
2. Enhanced --watch Flag
• Automatic log streaming (like --tail behavior)
• Live patching mode after log streaming completes
• Clear user feedback throughout the process
• Graceful shutdown with Ctrl+C
3. Deprecated Flags
• --publish: [DEPRECATED] - now default behavior
• --promote: [DEPRECATED] - use --environment {env_name} instead
• Both flags: Show deprecation warnings and migration guidance
• Removal: Will be removed in the following release
4. Environment-Based Deployment
• --environment production: Explicit production deployment
• --environment {env_name}: Environment-specific deployments
• Flexible: Supports any environment configuration
🚫 Breaking Changes & Migration
Breaking Changes
• Default behavior changed: truss push now creates published (was development)
• Chains default changed: truss chains push now creates published (was development)
Migration Path
Backward Compatibility
• --publish: Still works, shows deprecation warning
• --promote: Still works, shows deprecation warning
• All existing workflows: Continue to function with proper warnings