Validate config.yaml fields depending on transport kind, fix model wrapper test #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saptarshi-baseten
changed the title
squidarth
reviewed
Jul 18, 2025
truss/base/truss_config.py
Outdated
There was a problem hiding this comment.
why do you need to do getattr here? we've already checked that docker_server is not None, right?
There was a problem hiding this comment.
Yes docker_server is not None, but I think we need getattr to be able to check arbitrary fields in a loop like this (docker_server.server_port, etc.)
saptarshi-baseten
force-pushed
the
saptarshibhattacherya/bt-15014-dont-allow-dev-models-for-grpc
branch
from
2cb1ca5 to
8228ec8
Compare
spal1
reviewed
Jul 25, 2025
| apply_library_patches: bool = True | ||
| spec_version: str = "2.0" | ||
|
|
||
| DOCKER_SERVER_OPTIONAL_FIELDS: ClassVar[list[str]] = [ |
There was a problem hiding this comment.
these are only optional in the case of grpc right? can we rename this to be clearer
spal1
reviewed
Jul 25, 2025
| }, | ||
| "Please define server_port, predict_endpoint, readiness_endpoint, and liveness_endpoint for docker_server", | ||
| id="invalid-http-missing-fields", | ||
| ), |
There was a problem hiding this comment.
would be good to add a case for websockets
spal1
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
docker_serversection has the expected fields depending on whether or not the deployment is gRPCtest_model_wrapper.py::test_trt_llm_truss_missing_model_pywhich was failing in CI🔬 Testing
docker_serveris not present or has unexpected fields for gRPC deployments