Skip to content

add suport for python3 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

raonyguimaraes
Copy link

@raonyguimaraes raonyguimaraes commented Aug 8, 2016

Here is my working branch

@dtenenba
Copy link

It would be great if this could be merged. Python 3 support is important; python 3 was released 8 years ago and is considered "the present and future" of the language. Teams that use python 3 are having difficulty because the BaseSpace python SDK does not support it yet. Thanks for the PR @raonyguimaraes .

@psaffrey-illumina
Copy link
Contributor

Sorry this has languished for a while. Are you able to run the unit tests to ensure there are no regressions here? There should be instructions in the test/unit_tests.py directory.

Thank you very much for taking the time to make this PR.

@dtenenba
Copy link

It looks like this PR is a non-backwards compatible change. Is that the intention, to drop python 2.7 support?

If not, maybe another approach would be to use the six module to produce code that will run under both python 2 and 3.

I may look into producing a PR like this by using the sixer module, but first I need to figure out how to run unit tests (see #22). It would be great if we could use Travis or similar to run unit tests under python 2 and 3 with every push.

@alaindomissy
Copy link

Master branch is Python 2.6 only
Illumina, seriously ?

@dtenenba
Copy link

Looks like my PR was merged into the develop branch. Hope it can be merged into master.

@psaffrey-illumina
Copy link
Contributor

psaffrey-illumina commented Jan 17, 2018

Yes, master is way out of date. The develop branch is better but I'm afraid this SDK is not really supported anymore - sorry about this.

@raonyguimaraes
Copy link
Author

Is there anything we can do?

@psaffrey-illumina
Copy link
Contributor

This is a great offer, thanks, and I'm just trying to resolve some things at our end before deciding what to do next.

@bgruening
Copy link

@psaffrey-illumina is there any news here? It's 2022 - what is the plan for Illumina Community support for BaseSpace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants