-
Notifications
You must be signed in to change notification settings - Fork 30
add suport for python3 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
It would be great if this could be merged. Python 3 support is important; python 3 was released 8 years ago and is considered "the present and future" of the language. Teams that use python 3 are having difficulty because the BaseSpace python SDK does not support it yet. Thanks for the PR @raonyguimaraes . |
Sorry this has languished for a while. Are you able to run the unit tests to ensure there are no regressions here? There should be instructions in the test/unit_tests.py directory. Thank you very much for taking the time to make this PR. |
It looks like this PR is a non-backwards compatible change. Is that the intention, to drop python 2.7 support? If not, maybe another approach would be to use the I may look into producing a PR like this by using the |
Master branch is Python 2.6 only |
Looks like my PR was merged into the |
Yes, master is way out of date. The develop branch is better but I'm afraid this SDK is not really supported anymore - sorry about this. |
Is there anything we can do? |
This is a great offer, thanks, and I'm just trying to resolve some things at our end before deciding what to do next. |
@psaffrey-illumina is there any news here? It's 2022 - what is the plan for Illumina Community support for BaseSpace? |
Here is my working branch