Merged
Conversation
…d PixMetadataRequest
…ctRequest instances
…building customer request instances
…ding coupon request instances
…ilding billing request instances
gvieira18
reviewed
Oct 28, 2025
| } | ||
|
|
||
| if ($errors !== []) { | ||
| throw new InvalidArgumentException('Missing required fields: '.implode(', ', $errors)); |
Member
There was a problem hiding this comment.
All builders use the same Exception. Maybe this can be a custom exception where the static method receives the errors and constructs the message.
thow new AbacatePayException::missingRequiredFields($errors);
Contributor
There was a problem hiding this comment.
Let's change it later on. We need to ship a new version for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Builder pattern across all request (
Request) classes in the SDK.Added dedicated builders for each resource: Billing, Customer, Pix, Withdraw, and related objects.
Introduced a static
builder()method for all classes supporting fluent construction.Added automatic validation of required fields during the
build()process.Updated the README with:
Goal: improve readability, safety, and consistency when creating requests within the SDK.