Skip to content

chore: add enchance config file and lint#2

Merged
Clintonrocha98 merged 7 commits into1.xfrom
chore/add-cfg-file-conding-and-testing
Oct 28, 2025
Merged

chore: add enchance config file and lint#2
Clintonrocha98 merged 7 commits into1.xfrom
chore/add-cfg-file-conding-and-testing

Conversation

@gvieira18
Copy link
Member

@gvieira18 gvieira18 commented Oct 28, 2025

This pull request introduces several improvements to the project's configuration, development tooling, and code quality enforcement. The main changes include adding and updating configuration files for code style, static analysis, and testing, as well as enhancing composer scripts and dependencies. Additionally, some minor code cleanups and method refactorings are present in entity collection classes.

Development tooling and configuration:

  • Added .editorconfig and .gitattributes to enforce consistent editor and export-ignore settings across the project.
  • Updated composer.json to include a license, sort packages, add new dev dependencies (phpstan, pest-plugin-type-coverage), and provide scripts for linting, testing, and refactoring.
  • Added phpstan.neon for static analysis configuration and enhanced rector.php with improved preset usage and custom skip rules.
  • Updated phpunit.xml to enforce stricter test suite settings and randomize execution order.
  • Switched the pint.json preset to "laravel" and added more formatting rules for code style consistency.

Entity collection refactoring:

  • Refactored fromArray static constructors in BillingEntityCollection, CouponCollection, and CustomerEntityCollection to reside only in one place per class, improving clarity and reducing duplication.

Minor code and validation improvements:

  • Minor code cleanups such as property order adjustments and formatting tweaks in several entity and builder classes.
  • Improved validation logic in request builder classes for more idiomatic empty array checks and missing parameter detection.

@Clintonrocha98 Clintonrocha98 merged commit c419f3c into 1.x Oct 28, 2025
Copy link
Contributor

@danielhe4rt danielhe4rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gvieira18 gvieira18 deleted the chore/add-cfg-file-conding-and-testing branch October 28, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants