Skip to content

Fix duplicate policy and reduce number of splits #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mfickers
Copy link
Member

@mfickers mfickers commented Oct 2, 2024

No description provided.

Copy link
Collaborator

@lsiebels lsiebels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement! 👍🏻

@FinnReinhardtBsc
Copy link

FinnReinhardtBsc commented Oct 7, 2024

Fix PR-Title

dupliace => duplicate

Copy link

@FinnReinhardtBsc FinnReinhardtBsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer to use explicit initialization as opposed to inline initialization (see L96). But it does the job :D

@lsiebels lsiebels changed the title Fix dupliace policy and reduce number of splits Fix duplicate policy and reduce number of splits Oct 7, 2024
@lsiebels lsiebels merged commit 06c0ac7 into main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants