Repository navigation
Update Thruster to 0.1.27 - #360
Open
namespaceMarcello wants to merge 1 commit into
Open
namespaceMarcello wants to merge 1 commit into
namespaceMarcello wants to merge 1 commit into
Conversation
Thruster 0.1.24 and 0.1.27 fix two published advisories in its HTTP cache: GHSA-m592-hhcw-jh6f, "cache-key collisions allow cross-request response substitution", and GHSA-g74j-pv38-jj8g, "HTTP cache ignores later Vary field lines and repeated request header values". Campfire's public responses go through that cache: avatars, the account logo, files and assets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Campfire's lockfile has Thruster at 0.1.23. Two advisories in Thruster's HTTP cache have been published and fixed since:
Campfire's public responses go through that cache: avatars, the account logo, Active Storage files and what is in
public/. Whether either advisory can be reached in Campfire wasn't looked into here. This moves the lockfile to the fixed release and nothing else:bundle lock --update thruster --conservative, four lines.bundler-auditdoesn't point at this: it finds nothing in either lockfile, since ruby-advisory-db (at a6847b0, 2026-10-10) doesn't list the two advisories.What else comes with 0.1.24 to 0.1.27, from Thruster's changelog: requests that can't be cached bypass the cache altogether (0.1.25), an
X-Request-IDon requests, responses and logs (0.1.26), Go 1.27.1 and updated dependencies, golang.org/x/crypto 0.56.0 among them (0.1.27).What someone running Campfire could notice, as seen on the production image:
request_id: the id Rails tags its own log lines with and returns asX-Request-Id.public/(assets,robots.txt) carry anX-Request-Idtoo. They had none.Checks
On our machine (a laptop, Docker), with the production image built from
mainat edbc779 and from this branch, over plain HTTP:<video>asks,HEAD, conditional requests, with and without compression accepted, a thumbnail, an avatar, the logo, a bot's default avatar, a file of no bytes, a PDF, a stylesheet and a script,robots.txt, an asset that isn't there. The same status and the same decoded bytes in all 36.Not tried: TLS (
TLS_DOMAINand Let's Encrypt), and so not HTTP/2 either.Validation in the container:
bin/brakeman,bin/rails herb:check,bin/rails test(580 runs) andbin/rails test:system(27 runs) pass with no failures. They run in the test environment, where there is no Thruster: they say the lockfile resolves and the suite passes, and the checks above say the rest.Written by Claude Code (AI assistant) on behalf of @namespaceMarcello, who directs this work.
🤖 Generated with Claude Code