-
Notifications
You must be signed in to change notification settings - Fork 778
feat: enhance PS1 #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: enhance PS1 #579
Conversation
ImmortalSom
commented
Nov 24, 2025
- with dynamic Nerd Font icon for GUI terminals, fallback to standard prompt in TTY
- with dynamic Nerd Font icon for GUI terminals, fallback to standard prompt in TTY
Kasui92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this moves quite far from the project’s “Omakase” vision. Conceptually it’s fine and it does make things more flexible, but since it would still require users to customize it to handle “unexpected” cases or override the configuration directly, it’s better to keep a clean default setup and focus on making it easy to extend or override through someone’s own bash profiles.
|
The problem is that something can go wrong during installation, or you can connect to your computer via ssh and see a strange square when you log in as a user. Again, Omakub allows you to install only terminal programs, and in these cases the symbol will be broken everywhere. This is not an intrusion into Omakub field, it is a patch for exceptional cases. |
Exactly! I think the best solution is to drop the option to install only the terminal setup. I get why it exists, but focusing solely on the full desktop experience would make things much simpler for everyone, users and maintainers. |
|
Yes, happy just to focus on the desktop setup. I never ended up using the terminal-only setup. |
|
I'm probably misunderstanding something, or because I'm using a translator, I'm not getting my point across very well. This doesn't make any changes to the desktop. It just allows you to show the standard OS prompt for input where it's not possible to show this symbol. It's just that this symbol is only available in the Nord Font family, and if it's not there or you're not in GUI mode, the input prompt will either be empty or a rectangle, which can be confusing. Such situations can arise if something went wrong or someone deleted the fonts, or there was a network failure and the fonts were not installed, or you logged into the computer via ssh to do something, or the X/Wayland session crashed, or 100 other reasons. The first time this happened to me, it was exactly one of these reasons, and I stared at a blank screen for several minutes, not understanding where my prompt was. |
|
I think I understand the reasoning behind the change, and I'm not saying it's wrong. There are several valid scenarios where it could make sense. That said, I don't really see the need for it. It's meant to be a default provided by the installation, and anyone who wants the previous setup can simply override it. By default, Omakub ships with that font and is expected to render characters and icons correctly. If someone chooses not to use it, fixing the PS1 becomes their own responsibility. I wouldn’t worry about handling fallbacks or trying to cover every error case. But ... I won’t argue against it either. |
|
I was curious about Omarchy. Were there really no complaints there either? It turns out Omarchy installed Starship on August 17th and has no issues in console mode. |
|
But Omarchy works differently: it uses |