-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raspberry pi compatibility #227
Open
IbrahimTanyalcin
wants to merge
9
commits into
basecamp:master
Choose a base branch
from
IbrahimTanyalcin:raspi5-compat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2024
IbrahimTanyalcin
force-pushed
the
raspi5-compat
branch
from
July 26, 2024 18:07
4dec8e0
to
abcf738
Compare
Hey @IbrahimTanyalcin can you rebase off the latest |
IbrahimTanyalcin
force-pushed
the
raspi5-compat
branch
from
July 27, 2024 22:44
abcf738
to
dd3c4a8
Compare
@rmacklin Thanks for letting me know, I've rebased, there were no merge conflicts. |
… snap neovim to usr/local/bin/nvim
IbrahimTanyalcin
force-pushed
the
raspi5-compat
branch
from
August 3, 2024 08:30
dd3c4a8
to
b22531c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to try Omakub in my raspberry pi5, however ran into premature termination of the script in multiple places. These modifications should not change anything for amd64 but allow installation of most of the apps in raspberry. In the end I was able to have all the good bits working except these:
So I finally was able to try Omakub like in the introductin video, and it is really cool! Window tiles and shortcuts are great!
Here are the changes:
utils.sh
to deal with vendor imcompatibilities when naming architechtures amd64 vs x86_64, aarch64 vs arm64 etc.dpkg --print-architechture
is not enough to deal with all the incosistencies so there is an extendablearch_config
variable for future apps.XDG_CURRENT_DESKTOP
is not onlyGNOME
butubuntu:GNOME
, so made some changes to deal with possible variations without breaking current behavioramd64
andx86_64
and replaced them with output ofget_arch
, the output defaults to lscpu's values but can be customized based on app by adding keys toarch_config
array inutils.sh
set -e
(I undestand the intention of putting set -e but when something goes wrong you are left with a broken install anyway). So if one of the apps fail, the parent script will continue unless there is something else in the parent script that triggersset -e
, that behavior is left unchanged. The failed apps are reported in a formated way inside the root folder calledomakub_report.log
.utils.sh
calledhandle_omakub_source_error
andhandle_omakub_source_success
which are used byprint_omakub_report | tee ~/.local/share/omakub/omakub_report.log
, this will list all the successful and failed ones. Currently in rasberry pi 5, I only had 5 failed which some of them do not have arm64 releases.These changes should not introduce any breaking changes or modifications for
amd64
but will allow people to install and give Omakub a try in their arm64 devices and track what failed or not down the line.*** Please test this in your
amd64
machines and verify I did not accidentally introduced breaking changes. ***