MariaDB client support #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix systems using libtool do not need to do a version check against the client version string as the libraries themselves are versioned.
libmariadb-client-lgpl-dev in newly released Debian stable (jessie) ships `/usr/bin/mariadb_config`.
See also makandra@56b46c8
jeremy
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the Backpack Ruby 2.5.9 upgrade: https://github.com/basecamp/backpack/pull/247
I've cherry picked some commits, and adapted one from the Makandra mysql2 LTS branch: https://github.com/makandra/mysql2/tree/0.2.x-lts
These commits mean that we can use the official Ruby docker images, which are based on Debian, where the mysql client is less readily available. Now we can use a more recent version of Debian.
Please see the individual commits.
cc @basecamp/sip