Attachment interaction bugfixes #442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is an attachment between multiline paragraphs, the up/down arrow behaved unexpectedly: no matter where the cursor was in the paragraph, up/down selected the previous/next attachment, instead of moving within the paragraph. These changes fix that issue.
This change fixes a bug where an attachment was kept in a selected state, even if the cursor moved. Now node selection and selected classes are synchronized.
This change ensures a user can click above and below an attachment to start typing.
zoltanhosszu
force-pushed
the
bugfix+attachment-interactions
branch
from
48b30aa to
a6a9023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few behaviors around attachments, focusing on mostly UX improvements.
@jorgemanrubia would love your input on these! 91f4388 especially seems like a lot of code to fix some weirdness around the up/down arrow interaction, so maybe you have a better approach for that issue?