Fix --container-id to produce log output#1851
Open
airblade wants to merge 1 commit into
Open
Conversation
In order to pipe echo into xargs the command needs to run under a shell. Fixes basecamp#1841
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes kamal app logs --container-id so the provided container ID is emitted from a shell command before being piped into xargs docker logs, matching how the rest of the command pipeline is executed.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Wrap string/symbol
container_idvalues insh -cbefore piping toxargs. - Update command-level expectations for
logsandfollow_logsto reflect the new shell-wrapped form. - Update CLI follow-log test coverage for the adjusted SSH command quoting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/kamal/commands/app/logging.rb |
Fixes command construction for explicit container IDs so piped log retrieval works. |
test/commands/app_test.rb |
Updates low-level command output expectations for log commands using container_id. |
test/cli/app_test.rb |
Updates CLI follow-log expectation to match the new shell-wrapped SSH command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
BTW the CI test failures are nothing to do with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to pipe echo into xargs the command needs to run under a shell.
Fixes #1841