Mobile / Fix expanded column not being scrolled into view#2484
Merged
Mobile / Fix expanded column not being scrolled into view#2484
Conversation
Contributor
|
@adjogima the change looks good to me. Does it feel ok when switching between columns now (after the board has loaded) that we don't have smooth scrolling? |
Contributor
Author
|
@jayohms I went back and changed it to "instant" when restoring the previously expanded column but "smooth" when switching between columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an iOS-only bug where navigating to a board would often fail to bring the expanded column centered into view.
Safari seems to have trouble honoring the
scrollIntoViewcall, especially in the web views.I've played with disabling view transitions in the apps, adding a delay before triggering a scroll, implementing a custom
scrollColumnIntoViewfunction for this controller but nothing worked reliably.What seems to work reliably is switching from
smoothscrolling toinstantin the apps.