Skip to content

Improve QR code appearance in dark mode #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nqst wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −2
Open

Improve QR code appearance in dark mode #2456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b83ccce
Add padding to QR code images
nqst Jan 29, 2026
999d94b
Round the corners
nqst Jan 29, 2026
a4cf076
Use `inline-size` to preserve aspect-ratio
nqst Jan 30, 2026
2e28241
Add vertical spacing
nqst Jan 30, 2026
cfb3109
Clamp QR code size
nqst Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/assets/stylesheets/qr-codes.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
@layer components {
.qr-code {
aspect-ratio: 1;
block-size: 50dvh;
border-radius: 1ch;
inline-size: clamp(20ch, 50dvh, 70ch);
margin-block: var(--block-space);
}
}
2 changes: 1 addition & 1 deletion app/controllers/qr_codes_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def show

qr_code_svg = RQRCode::QRCode
.new(QrCodeLink.from_signed(params[:id]).url)
.as_svg(viewbox: true, fill: :white, color: :black)
.as_svg(viewbox: true, fill: :white, color: :black, offset: 16)

render svg: qr_code_svg
end
Expand Down