-
Notifications
You must be signed in to change notification settings - Fork 22
Add repeatable --attach flags for card and comment rich text #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e8db9f8
Add ergonomic inline attachment flags
robzolkos 8299bb9
Address PR review feedback on attach updates
robzolkos 81ebc5e
Fix lint shadowing in attach update paths
robzolkos b51dbc5
Address remaining PR review comments
robzolkos 1d4c482
Update internal/commands/upload.go
robzolkos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| package clitests | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "path/filepath" | ||
| "strconv" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestCardAttachFlag(t *testing.T) { | ||
| h := newHarness(t) | ||
| boardID := createBoard(t, h) | ||
| imagePath := fixtureFile(t, "test_image.png") | ||
| docPath := fixtureFile(t, "test_document.txt") | ||
|
|
||
| t.Run("creates card with single attach and downloads it", func(t *testing.T) { | ||
| title := fmt.Sprintf("Attach Flag Card %d", time.Now().UnixNano()) | ||
| result := h.Run("card", "create", "--board", boardID, "--title", title, "--attach", imagePath) | ||
| assertOK(t, result) | ||
|
|
||
| cardNumber := result.GetNumberFromLocation() | ||
| if cardNumber == 0 { | ||
| cardNumber = result.GetDataInt("number") | ||
| } | ||
| if cardNumber == 0 { | ||
| t.Fatalf("failed to get card number from create (location: %s)", result.GetLocation()) | ||
| } | ||
|
|
||
| showResult := h.Run("card", "attachments", "show", strconv.Itoa(cardNumber)) | ||
| assertOK(t, showResult) | ||
| arr := showResult.GetDataArray() | ||
| if len(arr) != 1 { | ||
| t.Fatalf("expected 1 attachment, got %d", len(arr)) | ||
| } | ||
| attachment := asMap(arr[0]) | ||
| if got := mapValueString(attachment, "filename"); got != "test_image.png" { | ||
| t.Fatalf("expected filename test_image.png, got %v", got) | ||
| } | ||
|
|
||
| outputPath := filepath.Join(t.TempDir(), "test_image.png") | ||
| downloadResult := h.Run("card", "attachments", "download", strconv.Itoa(cardNumber), "1", "-o", outputPath) | ||
| assertOK(t, downloadResult) | ||
| assertFileExists(t, outputPath) | ||
| }) | ||
|
|
||
| t.Run("creates card with multiple attaches in order", func(t *testing.T) { | ||
| title := fmt.Sprintf("Attach Flag Multi Card %d", time.Now().UnixNano()) | ||
| result := h.Run( | ||
| "card", "create", | ||
| "--board", boardID, | ||
| "--title", title, | ||
| "--description", "See attached files", | ||
| "--attach", imagePath, | ||
| "--attach", docPath, | ||
| ) | ||
| assertOK(t, result) | ||
|
|
||
| cardNumber := result.GetNumberFromLocation() | ||
| if cardNumber == 0 { | ||
| cardNumber = result.GetDataInt("number") | ||
| } | ||
|
|
||
| showResult := h.Run("card", "attachments", "show", strconv.Itoa(cardNumber)) | ||
| assertOK(t, showResult) | ||
| arr := showResult.GetDataArray() | ||
| if len(arr) != 2 { | ||
| t.Fatalf("expected 2 attachments, got %d", len(arr)) | ||
| } | ||
| if got := mapValueString(asMap(arr[0]), "filename"); got != "test_image.png" { | ||
| t.Fatalf("expected first attachment test_image.png, got %v", got) | ||
| } | ||
| if got := mapValueString(asMap(arr[1]), "filename"); got != "test_document.txt" { | ||
| t.Fatalf("expected second attachment test_document.txt, got %v", got) | ||
| } | ||
| }) | ||
|
|
||
| t.Run("works with description_file", func(t *testing.T) { | ||
| descriptionFile := filepath.Join(t.TempDir(), "description.md") | ||
| mustWriteFile(t, descriptionFile, []byte("See file-based content")) | ||
|
|
||
| title := fmt.Sprintf("Attach Flag File Card %d", time.Now().UnixNano()) | ||
| result := h.Run( | ||
| "card", "create", | ||
| "--board", boardID, | ||
| "--title", title, | ||
| "--description_file", descriptionFile, | ||
| "--attach", imagePath, | ||
| ) | ||
| assertOK(t, result) | ||
|
|
||
| cardNumber := result.GetNumberFromLocation() | ||
| if cardNumber == 0 { | ||
| cardNumber = result.GetDataInt("number") | ||
| } | ||
|
|
||
| showResult := h.Run("card", "attachments", "show", strconv.Itoa(cardNumber)) | ||
| assertOK(t, showResult) | ||
| if got := len(showResult.GetDataArray()); got != 1 { | ||
| t.Fatalf("expected 1 attachment from description_file flow, got %d", got) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| func assertFileExists(t *testing.T, path string) { | ||
| t.Helper() | ||
| if _, err := os.Stat(path); err != nil { | ||
| t.Fatalf("expected file at %s: %v", path, err) | ||
| } | ||
| } | ||
|
|
||
| func mustWriteFile(t *testing.T, path string, content []byte) { | ||
| t.Helper() | ||
| if err := os.WriteFile(path, content, 0o644); err != nil { | ||
| t.Fatalf("failed to write %s: %v", path, err) | ||
| } | ||
| } | ||
|
|
||
| func TestCommentAttachFlag(t *testing.T) { | ||
| h := newHarness(t) | ||
| cardNumber := createCard(t, h, fixture.BoardID) | ||
| cardStr := strconv.Itoa(cardNumber) | ||
| imagePath := fixtureFile(t, "test_image.png") | ||
| docPath := fixtureFile(t, "test_document.txt") | ||
|
|
||
| t.Run("creates attachment-only comment with single attach", func(t *testing.T) { | ||
| before := h.Run("comment", "attachments", "show", "--card", cardStr) | ||
| assertOK(t, before) | ||
| beforeCount := len(before.GetDataArray()) | ||
|
|
||
| result := h.Run("comment", "create", "--card", cardStr, "--attach", imagePath) | ||
| assertOK(t, result) | ||
|
|
||
| showResult := h.Run("comment", "attachments", "show", "--card", cardStr) | ||
| assertOK(t, showResult) | ||
| arr := showResult.GetDataArray() | ||
| if len(arr) != beforeCount+1 { | ||
| t.Fatalf("expected %d comment attachments, got %d", beforeCount+1, len(arr)) | ||
| } | ||
| added := asMap(arr[len(arr)-1]) | ||
| if got := mapValueString(added, "filename"); got != "test_image.png" { | ||
| t.Fatalf("expected filename test_image.png, got %v", got) | ||
| } | ||
|
|
||
| outputPath := filepath.Join(t.TempDir(), "test_image.png") | ||
| downloadResult := h.Run("comment", "attachments", "download", "--card", cardStr, strconv.Itoa(len(arr)), "-o", outputPath) | ||
| assertOK(t, downloadResult) | ||
| assertFileExists(t, outputPath) | ||
| }) | ||
|
|
||
| t.Run("creates comment with multiple attaches in order", func(t *testing.T) { | ||
| before := h.Run("comment", "attachments", "show", "--card", cardStr) | ||
| assertOK(t, before) | ||
| beforeCount := len(before.GetDataArray()) | ||
|
|
||
| result := h.Run( | ||
| "comment", "create", | ||
| "--card", cardStr, | ||
| "--body", "See attached files", | ||
| "--attach", imagePath, | ||
| "--attach", docPath, | ||
| ) | ||
| assertOK(t, result) | ||
|
|
||
| showResult := h.Run("comment", "attachments", "show", "--card", cardStr) | ||
| assertOK(t, showResult) | ||
| arr := showResult.GetDataArray() | ||
| if len(arr) != beforeCount+2 { | ||
| t.Fatalf("expected %d comment attachments, got %d", beforeCount+2, len(arr)) | ||
| } | ||
|
|
||
| lastTwo := arr[len(arr)-2:] | ||
| if got := mapValueString(asMap(lastTwo[0]), "filename"); got != "test_image.png" { | ||
| t.Fatalf("expected first new attachment test_image.png, got %v", got) | ||
| } | ||
| if got := mapValueString(asMap(lastTwo[1]), "filename"); got != "test_document.txt" { | ||
| t.Fatalf("expected second new attachment test_document.txt, got %v", got) | ||
| } | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.