Skip to content

Don't quote bash_path in the bcq shim#5

Merged
jeremy merged 1 commit intomainfrom
flavorjones/fix-installer
Jan 20, 2026
Merged

Don't quote bash_path in the bcq shim#5
jeremy merged 1 commit intomainfrom
flavorjones/fix-installer

Conversation

@flavorjones
Copy link
Copy Markdown
Member

On linux, the previous version results in:

exec "/usr/bin/env bash" "$BCQ_ROOT/bin/bcq" "$@"

and a runtime failure:

.local/bin/bcq: line 4: /usr/bin/env bash: No such file or directory

On linux, the previous version results in:

    exec "/usr/bin/env bash" "$BCQ_ROOT/bin/bcq" "$@"

and a runtime failure:

    .local/bin/bcq: line 4: /usr/bin/env bash: No such file or directory
@flavorjones flavorjones requested a review from jeremy January 20, 2026 17:34
@jeremy jeremy merged commit 4fd78e0 into main Jan 20, 2026
@jeremy jeremy deleted the flavorjones/fix-installer branch January 20, 2026 17:45
jeremy pushed a commit that referenced this pull request Feb 19, 2026
On linux, the previous version results in:

    exec "/usr/bin/env bash" "$BCQ_ROOT/bin/bcq" "$@"

and a runtime failure:

    .local/bin/bcq: line 4: /usr/bin/env bash: No such file or directory
jeremy added a commit that referenced this pull request Mar 9, 2026
Rewrite Agent Invariants #1 and #5 to guide agents toward --md for
human-facing output and --json for parsing. Replace the flat output
modes code block with a goal-oriented table and add a CLI Introspection
section documenting --agent --help for command discovery.
jeremy added a commit that referenced this pull request Mar 9, 2026
- Narrow invariant #5: only messages/comments convert Markdown to HTML;
  todos, documents, and cards send --content as-is
- Fix --agent/--quiet description: errors still emit {ok:false,...} object
- Remove misleading "default when piped" claim; advise explicit --json/--md
- Add long, default, and usage fields to --agent --help JSON example
jeremy added a commit that referenced this pull request Mar 9, 2026
* Document output modes and CLI introspection in SKILL.md

Rewrite Agent Invariants #1 and #5 to guide agents toward --md for
human-facing output and --json for parsing. Replace the flat output
modes code block with a goal-oriented table and add a CLI Introspection
section documenting --agent --help for command discovery.

* Add --md flag to root help output

Surface the Markdown output flag in the curated FLAGS section of
basecamp --help, alongside --json and --quiet.

* Address PR review feedback on SKILL.md

- Narrow invariant #5: only messages/comments convert Markdown to HTML;
  todos, documents, and cards send --content as-is
- Fix --agent/--quiet description: errors still emit {ok:false,...} object
- Remove misleading "default when piped" claim; advise explicit --json/--md
- Add long, default, and usage fields to --agent --help JSON example
jeremy added a commit that referenced this pull request Mar 15, 2026
Document all four mention syntaxes in agent_notes annotations
(comment, message, chat commands) and update SKILL.md invariant #5
with the full syntax list and recommended workflow for agents.
jeremy added a commit that referenced this pull request Mar 15, 2026
Document all four mention syntaxes in agent_notes annotations
(comment, message, chat commands) and update SKILL.md invariant #5
with the full syntax list and recommended workflow for agents.
jeremy added a commit that referenced this pull request Mar 15, 2026
Document all four mention syntaxes in agent_notes annotations
(comment, message, chat commands) and update SKILL.md invariant #5
with the full syntax list and recommended workflow for agents.
jeremy added a commit that referenced this pull request Mar 15, 2026
Document all four mention syntaxes in agent_notes annotations
(comment, message, chat commands) and update SKILL.md invariant #5
with the full syntax list and recommended workflow for agents.
jeremy added a commit that referenced this pull request Mar 15, 2026
* Add deterministic mention syntax and harden fuzzy resolution

Introduce three deterministic mention paths that bypass fuzzy name
matching, giving agents and pipelines unambiguous control:

- [@name](mention:SGID) — zero API calls, caller-trusted SGID
- [@name](person:ID) — one API call, resolves against pingable set
- @sgid:VALUE — inline SGID embed for composability

ResolveMentions is restructured into three sequential passes (anchor →
@sgid → fuzzy @name), each producing <bc-attachment> tags that
subsequent passes skip.

Also hardens the existing fuzzy @name path with review fixes from #288:
- ResolvePersonByName resolves against pingable set only
- Expanded prefix regex to match after (, [, ", '
- Trailing-character bailout for hyphens and word-internal apostrophes
- Case-insensitive isInsideBcAttachment guard
- Chat auto-promotes text/plain → text/html when mentions resolve
- Fix double-escaping of HTML entities in mention: display text

* Update agent notes and SKILL.md for deterministic mention syntax

Document all four mention syntaxes in agent_notes annotations
(comment, message, chat commands) and update SKILL.md invariant #5
with the full syntax list and recommended workflow for agents.

* Clarify reMentionInput prefix comment to enumerate allowed characters

The comment said "punctuation" which was vague — enumerate the specific
characters (whitespace, >, (, [, ", ') to match the actual regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants