Fix --assignee filter ignored with --list

[jeremy]

Summary

• --assignee was silently dropped when combined with --list because listTodosInList never received the flag
• Forces unlimited fetch when assignee filtering is active so client-side filtering doesn't miss matches beyond the default SDK cap
• Applies --limit after filtering, not before

Closes #285

Test plan

• TestTodosListInListFiltersByAssignee — direct + group todos filtered by "me"
• TestTodosListInListAssigneeNumericIDIncludesGroupTodos — numeric ID resolves across groups
• TestTodosListInListAssigneeNoMatchReturnsEmpty — unknown assignee returns empty
• TestTodosListInListAssigneeLimitAppliedAfterFilter — --limit caps post-filter (fixture's first todo is a non-match)
• TestTodosListInListAssigneeNoGroupsFilters — no-groups fast path filtering
• TestTodosListInListAssigneeNoGroupsLimitAfterFilter — no-groups path limit-after-filter

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1310b505c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

This PR fixes basecamp todos list --list … --assignee … silently ignoring the assignee filter by wiring the flag through to the single-todolist code path and applying client-side assignee filtering (including group-nested todos).

Changes:

• Pass --assignee into listTodosInList and filter returned todos by assignee client-side.
• Adjust fetch/limit behavior to avoid missing assignee matches beyond the SDK default cap.
• Add focused unit tests covering assignee filtering and “limit after filter” behavior for both grouped and no-groups paths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/commands/todos.go	Wires --assignee into the --list path and adds client-side filtering + limit handling changes.
internal/commands/todos_test.go	Adds fixtures/transports and unit tests to validate assignee filtering (including group todos) and post-filter limiting.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Comments suppressed due to low confidence (1)

internal/commands/todos.go:515

• With assignee != "" you set sdkLimit = -1, but when the user does not pass --all or an explicit --limit (i.e. limit == 0), the result set becomes uncapped (default 100 no longer applies). This can unexpectedly return very large outputs and also prevents truncation notices from working as before. Consider applying the default cap (100) to the post-filter results when !all && limit == 0, while keeping totalCount as the full filtered count for notices.

	// When assignee filtering is active, fetch all so client-side filtering
	// doesn't miss matches beyond the default cap.
	sdkLimit := 0 // SDK default
	if all || assignee != "" {
		sdkLimit = -1
	} else if limit > 0 {
		sdkLimit = limit
	}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/commands/todos.go">

<violation number="1" location="internal/commands/todos.go:553">
P2: When `--assignee` is used without `--limit`/`--all`, the default 100-item cap is no longer applied, so this path can return unbounded results.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}