-
Notifications
You must be signed in to change notification settings - Fork 8
Add --on-hold flag to cards move command #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bce2d48
Add --on-hold flag to cards move command
nnemirovsky e74e703
Address PR review feedback
nnemirovsky b62594b
Remove temporary replace directive for SDK fork
nnemirovsky 6dd1f11
Address second round of PR review feedback
nnemirovsky d49a633
Address Copilot review feedback
nnemirovsky 6997cc0
Address second round of Copilot review feedback
nnemirovsky 79e89c0
Bump SDK to on-hold merge commit (PR 188)
jeremy 2911065
Add named-column on-hold test and update surface baseline
jeremy d9b602e
Improve error hint when card has no parent column
jeremy 7f30f0a
Tidy go.sum after rebase onto main
jeremy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: This pins the SDK to a pseudo-version (untagged commit) which should not be merged. Once basecamp/basecamp-sdk#188 is tagged, run
make bump-sdkto update to the proper release version — per AGENTS.md, go.mod should not be edited directly.Prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pseudo-version is intentional — SDK PR 188 merged to main but no tag has been cut yet. The bump was done via
make bump-sdk REF=4784bb2fda18which is the standard workflow per AGENTS.md. Once a tagged release is available, a follow-upmake bump-sdkwill pin to it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I've saved this as a new learning to improve future reviews.