Conversation
github-actions
bot
added
commands
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="e2e/smoke/smoke_lineup.bats">
<violation number="1" location="e2e/smoke/smoke_lineup.bats:34">
P1: Missing `--json` flag on the `update` command. Without it the output won't be a JSON envelope, so `assert_json_value '.ok' 'true'` will either fail or vacuously pass.</violation>
<violation number="2" location="e2e/smoke/smoke_lineup.bats:46">
P1: Missing `--json` flag on the `delete` command. Same issue as `update` — `assert_json_value` needs JSON output.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Pull request overview
Adds an account-scoped basecamp lineup list command (backed by a bumped Basecamp SDK) and updates documentation/coverage plus smoke tests to exercise the new functionality.
Changes:
- Add
basecamp lineup listcommand and wire it into the command catalog. - Update Basecamp SDK dependency/provenance to include lineup marker listing support.
- Extend smoke coverage for lineup to include
listand enable update/delete via listing.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/commands/lineup.go |
Registers new lineup list subcommand and returns marker lists via SDK. |
internal/commands/commands.go |
Adds list to the lineup command catalog actions. |
e2e/smoke/smoke_lineup.bats |
Adds a lineup list smoke test and attempts to chain update/delete from listing. |
internal/commands/tools.go |
Uses new SDK Tools().Create(ctx, id, title) signature to avoid create+update. |
go.mod / go.sum |
Bumps github.com/basecamp/basecamp-sdk/go to the referenced pseudo-version. |
internal/version/sdk-provenance.json |
Updates recorded SDK revision and bc3 API sync revision. |
skills/basecamp/SKILL.md |
Documents basecamp lineup list usage. |
API-COVERAGE.md |
Updates in-scope endpoint totals and lineup section description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43ca6bf9f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f4ec8655d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a new basecamp lineup list command (account-wide) and updates the CLI + tests/docs to reflect the expanded Lineup marker support, including an SDK bump to pick up the required API method.
Changes:
- Add
basecamp lineup listcommand and wire it into the command catalog. - Bump
github.com/basecamp/basecamp-sdk/goand simplifytools cloneto use the SDK’s new create signature. - Add/adjust smoke tests and update docs/coverage metadata to include the new endpoint.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/commands/lineup.go |
Adds the new lineup list subcommand that fetches and renders lineup markers. |
internal/commands/commands.go |
Updates command metadata so lineup advertises the new list action. |
internal/commands/tools.go |
Updates tools clone/create path to use the SDK’s new Create(ctx, id, title) signature. |
e2e/smoke/smoke_lineup.bats |
Adds a smoke test for lineup list and updates update/delete tests to locate a marker ID via list. |
e2e/smoke/.qa-allowlist |
Allowlists the new lineup list smoke test and updates notes for dependent tests. |
API-COVERAGE.md |
Increments endpoint counts and documents lineup markers as list/create/update/delete. |
skills/basecamp/SKILL.md |
Documents basecamp lineup list usage in the skill reference. |
go.mod |
Bumps the Basecamp SDK dependency to the new revision. |
go.sum |
Updates checksums for the bumped SDK version. |
internal/version/sdk-provenance.json |
Records the updated SDK and API provenance revisions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Adds a new basecamp lineup list command to expose account-wide lineup markers via the CLI, and wires it into docs, surface snapshots, and smoke coverage.
Changes:
- Introduce
basecamp lineup listcommand and register it in command catalog metadata. - Extend smoke tests and QA allowlist to cover lineup list (and lifecycle flows).
- Update user-facing docs and CLI surface snapshot to reflect the new command and endpoint coverage count.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills/basecamp/SKILL.md | Documents the new lineup list usage example. |
| internal/commands/lineup.go | Adds newLineupListCmd() and registers it under lineup. |
| internal/commands/commands.go | Updates command catalog metadata to include lineup list. |
| go.sum | Adds checksums for a basecamp-sdk pseudo-version. |
| e2e/smoke/smoke_lineup.bats | Expands lineup smoke coverage to include list + update/delete lifecycle. |
| e2e/smoke/.qa-allowlist | Allowlists the new/expanded lineup smoke tests for environments lacking the API. |
| API-COVERAGE.md | Updates endpoint totals and lineup section to include the list endpoint. |
| .surface | Records the new command/flags in the CLI surface snapshot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Adds a new basecamp lineup list command (account-wide marker listing) and updates the CLI surface, docs, and smoke coverage to include listing markers as part of the lineup lifecycle.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Add
basecamp lineup listcommand and expose it in command categories + surface snapshot. - Bump the Basecamp SDK dependency and update provenance metadata.
- Expand lineup smoke tests to cover list + full CRUD, and refresh API coverage/docs accordingly.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/commands/lineup.go |
Adds the lineup list subcommand that fetches and outputs lineup markers. |
internal/commands/commands.go |
Updates command catalog metadata so lineup advertises the new list action. |
.surface |
Records the new command and its inherited flags for CLI surface tracking. |
e2e/smoke/smoke_lineup.bats |
Extends lineup smoke coverage to include list + update + delete (CRUD lifecycle). |
e2e/smoke/.qa-allowlist |
Allowlists new lineup smoke tests for environments where the lineup API isn’t available. |
go.mod / go.sum |
Updates the SDK module version and checksums. |
internal/version/sdk-provenance.json |
Updates recorded SDK revision/version provenance. |
API-COVERAGE.md |
Updates endpoint totals and lineup section coverage to include list markers. |
skills/basecamp/SKILL.md |
Documents the new basecamp lineup list usage example. |
internal/commands/schedule.go |
Adapts schedule create/update requests to updated SDK pointer fields. |
internal/tui/workspace/views/schedule.go |
Adapts TUI schedule create request to updated SDK pointer fields. |
internal/commands/checkins.go |
Adapts check-in schedule hour/minute fields to updated SDK pointer fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26fad7acfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08000c7922
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds `basecamp lineup list` to fetch all markers for an account. Bumps the SDK to pick up ListLineupMarkers and the simplified CloneTool Create signature (title parameter moved into Create, removing the separate Update round-trip).
There was a problem hiding this comment.
Pull request overview
Adds the missing Lineup marker listing capability to the Basecamp CLI, aligning the CLI surface and docs with new SDK support for listing lineup markers and expanding smoke coverage to a full CRUD lifecycle.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Add
basecamp lineup listcommand (account-wide) and expose it in command categories/surface snapshots. - Bump
github.com/basecamp/basecamp-sdk/goto the specified newer revision and update provenance. - Expand smoke coverage for lineup to include list + update + delete and adjust API coverage/docs accordingly.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
internal/commands/lineup.go |
Adds the lineup list subcommand and wires it into the lineup command group. |
internal/commands/commands.go |
Includes list in the advertised actions for the lineup command. |
e2e/smoke/smoke_lineup.bats |
Converts lineup smoke to a CRUD lifecycle including list/update/delete. |
e2e/smoke/smoke_lifecycle.bats |
Removes old “out of scope” lineup update/delete placeholders. |
e2e/smoke/.qa-allowlist |
Allowlists the new lineup smoke tests where the API may not exist. |
API-COVERAGE.md |
Updates endpoint counts and lineup section to include list. |
skills/basecamp/SKILL.md |
Documents basecamp lineup list usage example. |
.surface |
Records new CLI surface entries for basecamp lineup list and its flags/subcommands. |
go.mod |
Bumps the Basecamp SDK dependency. |
go.sum |
Updates module sums to match the SDK bump. |
internal/version/sdk-provenance.json |
Updates SDK provenance metadata (version/revision/timestamp). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea8c427552
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
basecamp lineup listcommand to fetch all markers for an account1c33ce43(latest main, includes ListLineupMarkers, partial-update pointer fix, hill chart support)lineup listwith full CRUD lifecycleCompanion PRs
Test plan
go build ./...compilesgo mod tidycleanbin/cifully green