Skip to content

Skip user-authored lines in attachment size injection #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 2 commits into from
Mar 16, 2026
Merged

Skip user-authored lines in attachment size injection #323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d080f
Skip user-authored 📎 lines in attachment size injection
jeremy Mar 16, 2026
3cebe10
Remove preceding-line guard from attachment size injection
jeremy Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/commands/chat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,17 @@ func TestInjectAttachmentSizes_DuplicateFilenames(t *testing.T) {
assert.Equal(t, "📎 doc.pdf (2.0kb)", lines[2])
}

func TestInjectAttachmentSizes_InlineAttachment(t *testing.T) {
// HTMLToMarkdown for inline attachments produces "content\n📎 filename\n"
// where the marker follows non-empty content — must still be annotated.
text := "See \n📎 report.pdf\nreport.pdf"
attachments := []basecamp.CampfireLineAttachment{
{Filename: "report.pdf", ByteSize: 9_000},
}
got := injectAttachmentSizes(text, attachments)
assert.Contains(t, got, "📎 report.pdf (9.0kb)")
}

func TestChatLinesDisplayData_ReplacesContent(t *testing.T) {
lines := []basecamp.CampfireLine{
{
Expand Down
Loading