Conversation
Match the pagination pattern used by recordings, todos, events, etc. The flags thread through to both normal and watch modes, with --all and --page rejected under --watch since continuous polling makes them nonsensical. Truncation notices surface when results are capped.
Regenerate .surface with new --all/--limit/--page flags, remove the --limit baseline from .surface-skill-drift, and replace the "not supported" note in SKILL.md with usage documentation.
github-actions
bot
added
commands
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds pagination support to the basecamp timeline command so it matches the established list-command pattern across the CLI, including consistent truncation notices and updated surfaced docs/skill metadata.
Changes:
- Added
--limit,--all, and--pageflags totimeline, with shared validation and SDK list option wiring. - Rejected
--all/--pageunder--watch, while allowing--limitto cap each poll. - Added truncation notices for account, project, and person timeline list paths; updated surface/skill docs accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/commands/timeline.go |
Implements new pagination flags, validation, option building, truncation notices, and watch-mode constraints. |
skills/basecamp/SKILL.md |
Updates user-facing skill documentation to describe the new flags and --watch restrictions. |
.surface |
Adds the new flags to the surfaced CLI contract for basecamp timeline. |
.surface-skill-drift |
Removes the timeline --limit baseline entry now that the flag is part of the surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reorder checks in runTimelineWatch so --all/--page are rejected with the watch-specific message before validateTimelinePagination runs. Previously --watch --page 2 returned "only --page 1 is supported" instead of "--page cannot be used with --watch".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--limit,--all, and--pageflags to thetimelinecommand, matching the pagination pattern established byrecordings,todos,events, etc.--alland--pageare rejected under--watch(continuous polling makes them nonsensical;--limitis allowed to cap each poll cycle).surface,.surface-skill-drift, andSKILL.mdto reflect the new flagsTest plan
make checkpasses (lint, vet, unit tests, e2e, surface snapshot, skill drift, bare groups, naming, SDK provenance)basecamp timeline --all --limit 5returns mutual exclusion errorbasecamp timeline --watch --allreturns "cannot be used with --watch"basecamp timeline --watch --page 1returns "cannot be used with --watch"--limitbaseline removed (5 baselined, down from 6)Summary by cubic
Add
--limit,--all, and--pageto thebasecamp timelinecommand to match pagination used by other list commands, with truncation notices and clear guardrails. Also fix watch-mode flag handling so invalid combos return the correct--watcherror.New Features
--limit Ncaps results (default: 100).--allfetches everything.--page 1fetches a single page.--alland--limitare mutually exclusive;--pagecannot be combined with--allor--limit(only--page 1is supported).--watchrejects--alland--page;--limitis allowed per poll cycle..surfaceandskills/basecamp/SKILL.mdwith new flags and guidance.Bug Fixes
--watchmode,--all/--pagenow error with "cannot be used with --watch" (e.g.,--watch --page 2), instead of page-validation messages.Written for commit a1cf099. Summary will update on new commits.