Conversation
Matches the convention used by chat, schedule, boost, and people commands for bare command groups that advertise subcommands.
Verify bare invocation shows help, and --help/-h display the subcommand hint in the usage line.
github-actions
bot
added
commands
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Updates the tools command metadata to match the CLI’s “group command” usage convention and adds end-to-end coverage to ensure the help output for tools continues to display the subcommand placeholder in the usage line.
Changes:
- Update
toolscommandUsestring totools [action]for consistency with other command groups (e.g.,chat,schedule,boost,people). - Add new e2e tests asserting
basecamp toolsandbasecamp tools --help/-hdisplay expected help/usage output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/commands/tools.go | Adds [action] to the cobra Use string for the tools command to align with existing group-command conventions. |
| e2e/tools.bats | Adds e2e coverage for tools help output (group help and usage line subcommand placeholder). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The file only tests help output, not error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[action]to theUsefield of the tools command, matching the convention used bychat,schedule,boost, andpeoplefor bare command groupsTest plan
make test— all unit tests passmake test-e2e— all 293 e2e tests pass (3 new intools.bats)go vetandgolangci-lintpass cleanSummary by cubic
Add “[action]” to the
Usestring for thetoolscommand to match other command groups and clearly signal that a subcommand is required. Add e2e tests verifying help shows the subcommand hint and that a bare invocation shows help; also fix thetools.batsheader to reflect it only tests help output.Written for commit e7b28eb. Summary will update on new commits.