Skip to content

Add breadcrumbs for archived/trashed cards and messages#310

Merged
jeremy merged 2 commits intomainfrom
bc-9679135710
Mar 16, 2026
Merged

Add breadcrumbs for archived/trashed cards and messages#310
jeremy merged 2 commits intomainfrom
bc-9679135710

Conversation

@jeremy
Copy link
Copy Markdown
Member

@jeremy jeremy commented Mar 15, 2026

Summary

  • Extract cardsListBreadcrumbs() and messagesListBreadcrumbs() helpers, adding an "archived" breadcrumb that points users to basecamp recordings for non-active items
  • The cards list and messages list API endpoints only return active items with no --status filter available, so this improves discoverability of the recordings path
  • Document the active-only behavior in the agent skill reference

Test plan

  • New TestCardsListBreadcrumbs and TestMessagesListBreadcrumbs unit tests pass
  • go vet, make test, make test-e2e all green
  • Verify breadcrumbs render correctly: basecamp cards list --in <project> and basecamp messages list --in <project>

@jeremy jeremy requested a review from a team as a code owner March 15, 2026 22:06
Copilot AI review requested due to automatic review settings March 15, 2026 22:06
@github-actions github-actions bot added commands CLI command implementations tests Tests (unit and e2e) skills Agent skills enhancement New feature or request labels Mar 15, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds list-view breadcrumbs and documentation to improve discoverability of how to find non-active (archived/trashed) cards/messages via basecamp recordings, since cards list and messages list only return active items.

Changes:

  • Extracts cardsListBreadcrumbs() / messagesListBreadcrumbs() helpers and wires them into the list responses.
  • Adds an “archived” breadcrumb pointing to basecamp recordings … --status archived --in <project>.
  • Documents the active-only behavior in the Basecamp skill reference and adds unit tests for the breadcrumb helpers.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
skills/basecamp/SKILL.md Documents that cards list / messages list return only active items and points to recordings … --status archived/trashed.
internal/commands/cards.go Refactors list breadcrumbs into cardsListBreadcrumbs() and adds an archived/recordings breadcrumb.
internal/commands/cards_test.go Adds a unit test covering cardsListBreadcrumbs().
internal/commands/messages.go Refactors list breadcrumbs into messagesListBreadcrumbs() and adds an archived/recordings breadcrumb.
internal/commands/messages_test.go Adds a unit test covering messagesListBreadcrumbs().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/commands/messages.go Outdated
Comment thread internal/commands/cards.go Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/commands/cards.go">

<violation number="1" location="internal/commands/cards.go:222">
P2: Description says "Browse archived or trashed cards" but the suggested command only filters for `--status archived`. Either narrow the description to "Browse archived cards" or add a second breadcrumb for trashed cards.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread internal/commands/cards.go Outdated
Copilot AI review requested due to automatic review settings March 15, 2026 22:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds “archived” breadcrumbs to cards list and messages list output to direct users to the basecamp recordings command for non-active items, and documents the active-only behavior in the Basecamp skill reference.

Changes:

  • Extracted cardsListBreadcrumbs() and messagesListBreadcrumbs() helpers and added an archived breadcrumb pointing at basecamp recordings … --status archived.
  • Updated list commands to use the new breadcrumb helpers.
  • Documented the active-only behavior for cards list / messages list in skills/basecamp/SKILL.md and added unit tests for the breadcrumb helpers.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
skills/basecamp/SKILL.md Documents that cards list / messages list return active-only and points to `recordings … --status archived
internal/commands/cards.go Refactors list breadcrumbs into cardsListBreadcrumbs() and adds an archived breadcrumb.
internal/commands/cards_test.go Adds a unit test covering the new cards breadcrumbs helper.
internal/commands/messages.go Refactors list breadcrumbs into messagesListBreadcrumbs() and adds an archived breadcrumb.
internal/commands/messages_test.go Adds a unit test covering the new messages breadcrumbs helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/commands/messages.go Outdated
jeremy added 2 commits March 15, 2026 15:36
Extract breadcrumbs into cardsListBreadcrumbs() and
messagesListBreadcrumbs() helpers, adding an "archived" breadcrumb
that points users to `basecamp recordings` for non-active items.
The list endpoints only return active items and the API has no
status filter, so this improves discoverability of the recordings
path.
Note the recordings path for archived/trashed cards and messages
in the agent skill reference.
@jeremy jeremy merged commit 84f061c into main Mar 16, 2026
25 checks passed
@jeremy jeremy deleted the bc-9679135710 branch March 16, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands CLI command implementations enhancement New feature or request skills Agent skills tests Tests (unit and e2e)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants