Add breadcrumbs for archived/trashed cards and messages#310
Conversation
There was a problem hiding this comment.
Pull request overview
Adds list-view breadcrumbs and documentation to improve discoverability of how to find non-active (archived/trashed) cards/messages via basecamp recordings, since cards list and messages list only return active items.
Changes:
- Extracts
cardsListBreadcrumbs()/messagesListBreadcrumbs()helpers and wires them into the list responses. - Adds an “archived” breadcrumb pointing to
basecamp recordings … --status archived --in <project>. - Documents the active-only behavior in the Basecamp skill reference and adds unit tests for the breadcrumb helpers.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/basecamp/SKILL.md | Documents that cards list / messages list return only active items and points to recordings … --status archived/trashed. |
| internal/commands/cards.go | Refactors list breadcrumbs into cardsListBreadcrumbs() and adds an archived/recordings breadcrumb. |
| internal/commands/cards_test.go | Adds a unit test covering cardsListBreadcrumbs(). |
| internal/commands/messages.go | Refactors list breadcrumbs into messagesListBreadcrumbs() and adds an archived/recordings breadcrumb. |
| internal/commands/messages_test.go | Adds a unit test covering messagesListBreadcrumbs(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/commands/cards.go">
<violation number="1" location="internal/commands/cards.go:222">
P2: Description says "Browse archived or trashed cards" but the suggested command only filters for `--status archived`. Either narrow the description to "Browse archived cards" or add a second breadcrumb for trashed cards.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Pull request overview
Adds “archived” breadcrumbs to cards list and messages list output to direct users to the basecamp recordings command for non-active items, and documents the active-only behavior in the Basecamp skill reference.
Changes:
- Extracted
cardsListBreadcrumbs()andmessagesListBreadcrumbs()helpers and added anarchivedbreadcrumb pointing atbasecamp recordings … --status archived. - Updated list commands to use the new breadcrumb helpers.
- Documented the active-only behavior for
cards list/messages listinskills/basecamp/SKILL.mdand added unit tests for the breadcrumb helpers.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills/basecamp/SKILL.md | Documents that cards list / messages list return active-only and points to `recordings … --status archived |
| internal/commands/cards.go | Refactors list breadcrumbs into cardsListBreadcrumbs() and adds an archived breadcrumb. |
| internal/commands/cards_test.go | Adds a unit test covering the new cards breadcrumbs helper. |
| internal/commands/messages.go | Refactors list breadcrumbs into messagesListBreadcrumbs() and adds an archived breadcrumb. |
| internal/commands/messages_test.go | Adds a unit test covering the new messages breadcrumbs helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Extract breadcrumbs into cardsListBreadcrumbs() and messagesListBreadcrumbs() helpers, adding an "archived" breadcrumb that points users to `basecamp recordings` for non-active items. The list endpoints only return active items and the API has no status filter, so this improves discoverability of the recordings path.
Note the recordings path for archived/trashed cards and messages in the agent skill reference.
Summary
cardsListBreadcrumbs()andmessagesListBreadcrumbs()helpers, adding an "archived" breadcrumb that points users tobasecamp recordingsfor non-active itemscards listandmessages listAPI endpoints only return active items with no--statusfilter available, so this improves discoverability of the recordings pathTest plan
TestCardsListBreadcrumbsandTestMessagesListBreadcrumbsunit tests passgo vet,make test,make test-e2eall greenbasecamp cards list --in <project>andbasecamp messages list --in <project>