Skip to content

Add e2e test coverage for --jq flag #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 2 commits into from
Mar 16, 2026
Merged

Add e2e test coverage for --jq flag #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c3803
Add e2e test coverage for --jq flag
jeremy Mar 15, 2026
6b9c289
Tighten jq e2e assertions per review feedback
jeremy Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions e2e/core.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,22 @@ load test_helper
}


# JQ flag

@test "--jq implies --json" {
run basecamp --jq '.'
assert_success
is_valid_json
assert_json_not_null '.data.version'
}

@test "--jq extracts scalar" {
run basecamp --jq '.data.auth.status'
assert_success
[[ "$output" == "unauthenticated" ]]
}


# Error handling

@test "basecamp unknown command shows error" {
Expand Down
21 changes: 21 additions & 0 deletions e2e/errors.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,27 @@ load test_helper
}


# JQ flag errors

@test "--jq invalid expression shows error" {
create_credentials
run basecamp --jq '.[invalid'
assert_failure
assert_json_value '.ok' 'false'
assert_json_value '.code' 'usage'
assert_output_contains "invalid --jq expression"
}

@test "--jq conflicts with --ids-only" {
create_credentials
run basecamp --jq '.data' --ids-only
assert_failure
assert_json_value '.ok' 'false'
assert_json_value '.code' 'usage'
assert_json_value '.error' 'cannot use --jq with --ids-only'
}


# Missing content errors

@test "todo create without content shows error" {
Expand Down
Loading