Conversation
There was a problem hiding this comment.
Pull request overview
Adds optional positional placement for basecamp cards move so users can move a card into a specific index within the target column, while preserving the existing move behavior when no position is requested.
Changes:
- Add
--position/--postobasecamp cards moveand route positioned moves through the card table moves endpoint. - Extend unit tests with transport-backed coverage for positioned vs unpositioned move request contracts and for multi-table ambiguity.
- Update skill docs, smoke tests, allowlist, and surface snapshot to reflect the new flags and example usage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
skills/basecamp/SKILL.md |
Documents cards move with optional --position and adds examples. |
internal/commands/cards.go |
Implements --position/--pos and switches endpoint/payload when set. |
internal/commands/cards_test.go |
Adds transport-backed tests for positioned payload, legacy path, validation, and ambiguity. |
e2e/smoke/smoke_cards_write.bats |
Adds a smoke test covering cards move --position. |
e2e/smoke/.qa-allowlist |
Allowlists the new smoke test as unverifiable in some environments. |
.surface |
Updates CLI surface snapshot to include the new flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Allow placing a card at a specific position within the target column. Uses the card_tables moves endpoint (CardColumns().Move) with the card as source_id and the column as target_id. When --position is absent, the existing Cards().Move path is unchanged. Includes transport-backed tests proving the CLI request contract, validation tests for non-positive values, a multi-table ambiguity test, and a smoke e2e test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--position(alias--pos) flag tobasecamp cards movefor placing a card at a specific position within the target column (1-indexed)CardColumns().Moveendpoint (POST /card_tables/{id}/moves.json) with card-as-source, column-as-target; unpositioned moves use the existingCards().Movepath unchanged--positionis used with a numeric--tocolumn ID, the card table is auto-resolved (single table) or an ambiguous error guides the user to provide--card-tableTest plan
TestCardsMovePositionPayload— transport-backed test verifies CLI sends{source_id, target_id, position}to/card_tables/{id}/moves.jsonTestCardsMoveWithoutPositionUsesCardsMove— transport-backed test verifies old path/card_tables/cards/{id}/moves.jsonwith{column_id}when--positionabsentTestCardsMovePositionRejectsNonPositive— validates--position -1TestCardsMovePositionRejectsZero— validates--position 0TestCardsMovePositionNumericToMultiTableAmbiguous— multi-table + no--card-tablereturns ambiguous errorcards move with position moves card to positionbin/cipasses (all checks including skill drift)Summary by cubic
Adds a
--positionflag tobasecamp cards moveto place a card at a specific position in the target column. When omitted, existing move behavior is unchanged.--position(alias--pos) sets 1-indexed position in the target column.CardColumns().Move(POST /card_tables/{id}/moves.json) with{source_id, target_id, position}; otherwise uses existingCards().Move.--to, auto-resolves the card table; errors if multiple tables and no--card-table.--position> 0 and includespositionin JSON output and CLI summary..surface, e2e smoke test, andskills/basecamp/SKILL.md.Written for commit ea7857e. Summary will update on new commits.