Pad list widget output to allocated height#263
Merged
Conversation
List.View() emitted fewer lines than l.height when results didn't fill the viewport, causing content area collapse and chrome bleed-through. Wrap all return paths through a single lipgloss.Height(l.height) render, matching the kanban pattern.
There was a problem hiding this comment.
Pull request overview
This PR fixes a TUI rendering issue where the list widget could emit fewer lines than its allocated height, causing the surrounding layout/content area to collapse and reveal underlying chrome (notably when searching with few results). It aligns List.View() with the existing widget pattern (as used by Kanban) by always rendering to the widget’s configured height.
Changes:
- Refactors
List.View()to build output via a singlestrings.Builderacross all branches. - Ensures the final rendered output is padded/clamped to
l.height(andl.width) via a singlelipglossrender at the end ofView().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Cover few-items, empty, loading, and no-matches-filter states to verify the viewport always fills its allocated height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
View()emitted fewer lines thanl.heightwhen results didn't fill the viewport, causing content area collapse and blank space / chrome bleed-through (most visible in search with few results)lipgloss.Height(l.height)render at the end ofView(), matching the existing kanban patternTest plan
TestList_ScrollIndicator_NoOverflowstill passes (output now exactly fills height)TestList_HeightPadding_FewItems,TestList_HeightPadding_NoMatchesFilterTestList_HeightPadding_Empty,TestList_HeightPadding_Loading