Fix campfire output: typed slice and campfire_line schema#253
Merged
Conversation
singleLine previously returned only the first non-empty line, silently dropping the rest. Now it joins all non-empty lines with spaces so table cells show the full content compressed to one line. formatCell in the generic renderer gets the same treatment via strings.Fields for cells that contain \n or \r.
github-actions
bot
added
commands
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Fixes Campfire CLI human-readable output by ensuring Campfire responses flow through the schema-backed presenter path and by introducing an explicit campfire_line presenter schema for Campfire chat lines.
Changes:
- Add
campfire_linepresenter schema (list/detail) to avoid title/content duplication and provide consistent columns. - Fix
campfire listsingle-item output to use a typed slice so it’s normalized and rendered as a table instead of a struct dump. - Wire
WithEntity("campfire_line")into Campfire messages/post/line show outputs and add regression tests for schema loading + multiline collapsing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/presenter/schemas/campfire_line.yaml | New schema defining list/detail presentation for Campfire lines. |
| internal/presenter/presenter_test.go | Tests schema registration and verifies multiline content collapses in schema-backed list rendering. |
| internal/output/output_test.go | End-to-end styled output test for WithEntity("campfire_line"), including multiline collapse and absence of title column. |
| internal/commands/campfire.go | Uses typed slice for single-campfire list output and applies WithEntity("campfire_line") for line-based outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Normalize \r\n and bare \r to \n before splitting so carriage returns don't leak into table cells. Add test for bare-CR and mixed line endings. Drop unused require import from this commit (child PRs re-add it when they add tests that need it).
- Change []any{campfire} to []basecamp.Campfire{*campfire} so the typed
slice hits the JSON round-trip path instead of falling through to
fmt.Sprintf("%v") struct dump.
- Add campfire_line.yaml presenter schema with content, creator,
created_at columns — excludes title to prevent duplication. No
type_key since API lines use multiple types (Chat::Lines::Text,
Chat::Lines::Upload, Chat::Lines::RichText).
- Wire WithEntity("campfire_line") in messages, post, and show commands.
- Add presenter and output tests for the new schema.
jeremy
force-pushed
the
fix-campfire-output
branch
from
f73b673 to
b9625a7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeremy
force-pushed
the
fix-campfire-output
branch
from
b9625a7 to
bbd8f34
Compare
…er ANSI assertion
- Use []*basecamp.Campfire{campfire} to avoid struct copy
- Assert both "title" and "Title" absent from campfire_line output
- Widen ANSI check from \x1b[ to \x1b to catch OSC sequences
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #251.
Summary
[]any{campfire}→[]basecamp.Campfire{*campfire}so the typed slice hits the JSON round-trip path.campfire_line.yamlpresenter schema with[id, content, creator, created_at]columns — excludestitleto prevent content/title duplication.type_keysince API lines use multiple types (Chat::Lines::Text,Chat::Lines::Upload,Chat::Lines::RichText); commands use explicitWithEntity("campfire_line").WithEntityin messages, post, and line show commands.Test plan
bin/cipassesbasecamp campfires— formatted table, no struct dumpbasecamp campfire messages— no title/content duplication, multiline collapsed