Skip to content

Add attachment support: attach, upload, --attach, inline images #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 10 commits into from
Mar 11, 2026
Merged

Add attachment support: attach, upload, --attach, inline images #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f29a70
Add attachment support across CLI commands
jeremy Mar 10, 2026
e23280e
Address review feedback: HTML unescape, Windows paths, defer close, u…
jeremy Mar 10, 2026
feec2dd
Acknowledge surface removals for standalone uploads topology
jeremy Mar 11, 2026
e92e6d7
Update comment to reflect intentional deviation from RFC 3986
jeremy Mar 11, 2026
b900956
Resolve inline images in upload --description field
jeremy Mar 11, 2026
c02b456
Fix file:// URI handling, leading newline in attach-only, campfire br…
jeremy Mar 11, 2026
b33ffe9
Move --content-type flag from campfire parent to post subcommand
jeremy Mar 11, 2026
b825784
Include chat alias in content-type surface-breaking entries
jeremy Mar 11, 2026
48e4826
Fix upload breadcrumbs and surface-breaking entries
jeremy Mar 11, 2026
32303fc
Fix upload breadcrumb for root-level shortcut command
jeremy Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
506 changes: 177 additions & 329 deletions .surface
View file
Open in desktop

Large diffs are not rendered by default.

362 changes: 362 additions & 0 deletions .surface-breaking
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,365 @@ FLAG basecamp checkin answer create --question type=string
FLAG basecamp checkins answer create --question type=string
FLAG basecamp webhook create --url type=string
FLAG basecamp webhooks create --url type=string
ARG basecamp upload doc create 00 <title>
ARG basecamp upload doc create 01 [content]
ARG basecamp upload document create 00 <title>
ARG basecamp upload document create 01 [content]
ARG basecamp upload documents create 00 <title>
ARG basecamp upload documents create 01 [content]
ARG basecamp upload download 00 <upload-id|url>
ARG basecamp upload folder create 00 <name>
ARG basecamp upload folders create 00 <name>
ARG basecamp upload show 00 <id|url>
ARG basecamp upload update 00 <id|url>
ARG basecamp upload vault create 00 <name>
ARG basecamp upload vaults create 00 <name>
ARG basecamp uploads doc create 00 <title>
ARG basecamp uploads doc create 01 [content]
ARG basecamp uploads document create 00 <title>
ARG basecamp uploads document create 01 [content]
ARG basecamp uploads documents create 00 <title>
ARG basecamp uploads documents create 01 [content]
ARG basecamp uploads download 00 <upload-id|url>
ARG basecamp uploads folder create 00 <name>
ARG basecamp uploads folders create 00 <name>
ARG basecamp uploads update 00 <id|url>
ARG basecamp uploads vault create 00 <name>
ARG basecamp uploads vaults create 00 <name>
CMD basecamp upload doc
CMD basecamp upload doc create
CMD basecamp upload doc list
CMD basecamp upload document
CMD basecamp upload document create
CMD basecamp upload document list
CMD basecamp upload documents
CMD basecamp upload documents create
CMD basecamp upload documents list
CMD basecamp upload download
CMD basecamp upload folder
CMD basecamp upload folder create
CMD basecamp upload folder list
CMD basecamp upload folders
CMD basecamp upload folders create
CMD basecamp upload folders list
CMD basecamp upload list
CMD basecamp upload show
CMD basecamp upload update
CMD basecamp upload upload
CMD basecamp upload upload list
CMD basecamp upload uploads
CMD basecamp upload uploads list
CMD basecamp upload vault
CMD basecamp upload vault create
CMD basecamp upload vault list
CMD basecamp upload vaults
CMD basecamp upload vaults create
CMD basecamp upload vaults list
CMD basecamp uploads doc
CMD basecamp uploads doc create
CMD basecamp uploads doc list
CMD basecamp uploads document
CMD basecamp uploads document create
CMD basecamp uploads document list
CMD basecamp uploads documents
CMD basecamp uploads documents create
CMD basecamp uploads documents list
CMD basecamp uploads download
CMD basecamp uploads folder
CMD basecamp uploads folder create
CMD basecamp uploads folder list
CMD basecamp uploads folders
CMD basecamp uploads folders create
CMD basecamp uploads folders list
CMD basecamp uploads update
CMD basecamp uploads upload
CMD basecamp uploads upload list
CMD basecamp uploads uploads
CMD basecamp uploads uploads list
CMD basecamp uploads vault
CMD basecamp uploads vault create
CMD basecamp uploads vault list
CMD basecamp uploads vaults
CMD basecamp uploads vaults create
CMD basecamp uploads vaults list
FLAG basecamp upload doc --all type=bool
FLAG basecamp upload doc --help type=bool
FLAG basecamp upload doc --limit type=int
FLAG basecamp upload doc --page type=int
FLAG basecamp upload doc create --draft type=bool
FLAG basecamp upload doc create --help type=bool
FLAG basecamp upload doc create --no-subscribe type=bool
FLAG basecamp upload doc create --subscribe type=string
FLAG basecamp upload doc list --all type=bool
FLAG basecamp upload doc list --help type=bool
FLAG basecamp upload doc list --limit type=int
FLAG basecamp upload doc list --page type=int
FLAG basecamp upload document --all type=bool
FLAG basecamp upload document --help type=bool
FLAG basecamp upload document --limit type=int
FLAG basecamp upload document --page type=int
FLAG basecamp upload document create --draft type=bool
FLAG basecamp upload document create --help type=bool
FLAG basecamp upload document create --no-subscribe type=bool
FLAG basecamp upload document create --subscribe type=string
FLAG basecamp upload document list --all type=bool
FLAG basecamp upload document list --help type=bool
FLAG basecamp upload document list --limit type=int
FLAG basecamp upload document list --page type=int
FLAG basecamp upload documents --all type=bool
FLAG basecamp upload documents --help type=bool
FLAG basecamp upload documents --limit type=int
FLAG basecamp upload documents --page type=int
FLAG basecamp upload documents create --draft type=bool
FLAG basecamp upload documents create --help type=bool
FLAG basecamp upload documents create --no-subscribe type=bool
FLAG basecamp upload documents create --subscribe type=string
FLAG basecamp upload documents list --all type=bool
FLAG basecamp upload documents list --help type=bool
FLAG basecamp upload documents list --limit type=int
FLAG basecamp upload documents list --page type=int
FLAG basecamp upload download --help type=bool
FLAG basecamp upload download --out type=string
FLAG basecamp upload folder --all type=bool
FLAG basecamp upload folder --help type=bool
FLAG basecamp upload folder --limit type=int
FLAG basecamp upload folder --page type=int
FLAG basecamp upload folder create --help type=bool
FLAG basecamp upload folder list --all type=bool
FLAG basecamp upload folder list --help type=bool
FLAG basecamp upload folder list --limit type=int
FLAG basecamp upload folder list --page type=int
FLAG basecamp upload folders --all type=bool
FLAG basecamp upload folders --help type=bool
FLAG basecamp upload folders --limit type=int
FLAG basecamp upload folders --page type=int
FLAG basecamp upload folders create --help type=bool
FLAG basecamp upload folders list --all type=bool
FLAG basecamp upload folders list --help type=bool
FLAG basecamp upload folders list --limit type=int
FLAG basecamp upload folders list --page type=int
FLAG basecamp upload list --help type=bool
FLAG basecamp upload show --help type=bool
FLAG basecamp upload show --type type=string
FLAG basecamp upload update --content type=string
FLAG basecamp upload update --help type=bool
FLAG basecamp upload update --title type=string
FLAG basecamp upload update --type type=string
FLAG basecamp upload upload --all type=bool
FLAG basecamp upload upload --help type=bool
FLAG basecamp upload upload --limit type=int
FLAG basecamp upload upload --page type=int
FLAG basecamp upload upload list --all type=bool
FLAG basecamp upload upload list --help type=bool
FLAG basecamp upload upload list --limit type=int
FLAG basecamp upload upload list --page type=int
FLAG basecamp upload uploads --all type=bool
FLAG basecamp upload uploads --help type=bool
FLAG basecamp upload uploads --limit type=int
FLAG basecamp upload uploads --page type=int
FLAG basecamp upload uploads list --all type=bool
FLAG basecamp upload uploads list --help type=bool
FLAG basecamp upload uploads list --limit type=int
FLAG basecamp upload uploads list --page type=int
FLAG basecamp upload vault --all type=bool
FLAG basecamp upload vault --help type=bool
FLAG basecamp upload vault --limit type=int
FLAG basecamp upload vault --page type=int
FLAG basecamp upload vault create --help type=bool
FLAG basecamp upload vault list --all type=bool
FLAG basecamp upload vault list --help type=bool
FLAG basecamp upload vault list --limit type=int
FLAG basecamp upload vault list --page type=int
FLAG basecamp upload vaults --all type=bool
FLAG basecamp upload vaults --help type=bool
FLAG basecamp upload vaults --limit type=int
FLAG basecamp upload vaults --page type=int
FLAG basecamp upload vaults create --help type=bool
FLAG basecamp upload vaults list --all type=bool
FLAG basecamp upload vaults list --help type=bool
FLAG basecamp upload vaults list --limit type=int
FLAG basecamp upload vaults list --page type=int
FLAG basecamp uploads doc --all type=bool
FLAG basecamp uploads doc --help type=bool
FLAG basecamp uploads doc --limit type=int
FLAG basecamp uploads doc --page type=int
FLAG basecamp uploads doc create --draft type=bool
FLAG basecamp uploads doc create --help type=bool
FLAG basecamp uploads doc create --no-subscribe type=bool
FLAG basecamp uploads doc create --subscribe type=string
FLAG basecamp uploads doc list --all type=bool
FLAG basecamp uploads doc list --help type=bool
FLAG basecamp uploads doc list --limit type=int
FLAG basecamp uploads doc list --page type=int
FLAG basecamp uploads document --all type=bool
FLAG basecamp uploads document --help type=bool
FLAG basecamp uploads document --limit type=int
FLAG basecamp uploads document --page type=int
FLAG basecamp uploads document create --draft type=bool
FLAG basecamp uploads document create --help type=bool
FLAG basecamp uploads document create --no-subscribe type=bool
FLAG basecamp uploads document create --subscribe type=string
FLAG basecamp uploads document list --all type=bool
FLAG basecamp uploads document list --help type=bool
FLAG basecamp uploads document list --limit type=int
FLAG basecamp uploads document list --page type=int
FLAG basecamp uploads documents --all type=bool
FLAG basecamp uploads documents --help type=bool
FLAG basecamp uploads documents --limit type=int
FLAG basecamp uploads documents --page type=int
FLAG basecamp uploads documents create --draft type=bool
FLAG basecamp uploads documents create --help type=bool
FLAG basecamp uploads documents create --no-subscribe type=bool
FLAG basecamp uploads documents create --subscribe type=string
FLAG basecamp uploads documents list --all type=bool
FLAG basecamp uploads documents list --help type=bool
FLAG basecamp uploads documents list --limit type=int
FLAG basecamp uploads documents list --page type=int
FLAG basecamp uploads download --help type=bool
FLAG basecamp uploads download --out type=string
FLAG basecamp uploads folder --all type=bool
FLAG basecamp uploads folder --help type=bool
FLAG basecamp uploads folder --limit type=int
FLAG basecamp uploads folder --page type=int
FLAG basecamp uploads folder create --help type=bool
FLAG basecamp uploads folder list --all type=bool
FLAG basecamp uploads folder list --help type=bool
FLAG basecamp uploads folder list --limit type=int
FLAG basecamp uploads folder list --page type=int
FLAG basecamp uploads folders --all type=bool
FLAG basecamp uploads folders --help type=bool
FLAG basecamp uploads folders --limit type=int
FLAG basecamp uploads folders --page type=int
FLAG basecamp uploads folders create --help type=bool
FLAG basecamp uploads folders list --all type=bool
FLAG basecamp uploads folders list --help type=bool
FLAG basecamp uploads folders list --limit type=int
FLAG basecamp uploads folders list --page type=int
FLAG basecamp uploads update --content type=string
FLAG basecamp uploads update --help type=bool
FLAG basecamp uploads update --title type=string
FLAG basecamp uploads update --type type=string
FLAG basecamp uploads upload --all type=bool
FLAG basecamp uploads upload --help type=bool
FLAG basecamp uploads upload --limit type=int
FLAG basecamp uploads upload --page type=int
FLAG basecamp uploads upload list --all type=bool
FLAG basecamp uploads upload list --help type=bool
FLAG basecamp uploads upload list --limit type=int
FLAG basecamp uploads upload list --page type=int
FLAG basecamp uploads uploads --all type=bool
FLAG basecamp uploads uploads --help type=bool
FLAG basecamp uploads uploads --limit type=int
FLAG basecamp uploads uploads --page type=int
FLAG basecamp uploads uploads list --all type=bool
FLAG basecamp uploads uploads list --help type=bool
FLAG basecamp uploads uploads list --limit type=int
FLAG basecamp uploads uploads list --page type=int
FLAG basecamp uploads vault --all type=bool
FLAG basecamp uploads vault --help type=bool
FLAG basecamp uploads vault --limit type=int
FLAG basecamp uploads vault --page type=int
FLAG basecamp uploads vault create --help type=bool
FLAG basecamp uploads vault list --all type=bool
FLAG basecamp uploads vault list --help type=bool
FLAG basecamp uploads vault list --limit type=int
FLAG basecamp uploads vault list --page type=int
FLAG basecamp uploads vaults --all type=bool
FLAG basecamp uploads vaults --help type=bool
FLAG basecamp uploads vaults --limit type=int
FLAG basecamp uploads vaults --page type=int
FLAG basecamp uploads vaults create --help type=bool
FLAG basecamp uploads vaults list --all type=bool
FLAG basecamp uploads vaults list --help type=bool
FLAG basecamp uploads vaults list --limit type=int
FLAG basecamp uploads vaults list --page type=int
SUB basecamp upload doc
SUB basecamp upload doc create
SUB basecamp upload doc list
SUB basecamp upload document
SUB basecamp upload document create
SUB basecamp upload document list
SUB basecamp upload documents
SUB basecamp upload documents create
SUB basecamp upload documents list
SUB basecamp upload download
SUB basecamp upload folder
SUB basecamp upload folder create
SUB basecamp upload folder list
SUB basecamp upload folders
SUB basecamp upload folders create
SUB basecamp upload folders list
SUB basecamp upload list
SUB basecamp upload show
SUB basecamp upload update
SUB basecamp upload upload
SUB basecamp upload upload list
SUB basecamp upload uploads
SUB basecamp upload uploads list
SUB basecamp upload vault
SUB basecamp upload vault create
SUB basecamp upload vault list
SUB basecamp upload vaults
SUB basecamp upload vaults create
SUB basecamp upload vaults list
SUB basecamp uploads doc
SUB basecamp uploads doc create
SUB basecamp uploads doc list
SUB basecamp uploads document
SUB basecamp uploads document create
SUB basecamp uploads document list
SUB basecamp uploads documents
SUB basecamp uploads documents create
SUB basecamp uploads documents list
SUB basecamp uploads download
SUB basecamp uploads folder
SUB basecamp uploads folder create
SUB basecamp uploads folder list
SUB basecamp uploads folders
SUB basecamp uploads folders create
SUB basecamp uploads folders list
SUB basecamp uploads update
SUB basecamp uploads upload
SUB basecamp uploads upload list
SUB basecamp uploads uploads
SUB basecamp uploads uploads list
SUB basecamp uploads vault
SUB basecamp uploads vault create
SUB basecamp uploads vault list
SUB basecamp uploads vaults
SUB basecamp uploads vaults create
SUB basecamp uploads vaults list
ARG basecamp upload archive 00 <id|url>
ARG basecamp upload restore 00 <id|url>
ARG basecamp upload trash 00 <id|url>
ARG basecamp uploads archive 00 <id|url>
ARG basecamp uploads restore 00 <id|url>
ARG basecamp uploads trash 00 <id|url>
CMD basecamp upload archive
CMD basecamp upload restore
CMD basecamp upload trash
CMD basecamp uploads archive
CMD basecamp uploads restore
CMD basecamp uploads trash
FLAG basecamp upload archive --help type=bool
FLAG basecamp upload restore --help type=bool
FLAG basecamp upload trash --help type=bool
FLAG basecamp uploads archive --help type=bool
FLAG basecamp uploads restore --help type=bool
FLAG basecamp uploads trash --help type=bool
SUB basecamp upload archive
SUB basecamp upload restore
SUB basecamp upload trash
SUB basecamp uploads archive
SUB basecamp uploads restore
SUB basecamp uploads trash
FLAG basecamp campfire --content-type type=string
FLAG basecamp campfire delete --content-type type=string
FLAG basecamp campfire line --content-type type=string
FLAG basecamp campfire list --content-type type=string
FLAG basecamp campfire messages --content-type type=string
FLAG basecamp chat --content-type type=string
FLAG basecamp chat delete --content-type type=string
FLAG basecamp chat line --content-type type=string
FLAG basecamp chat list --content-type type=string
FLAG basecamp chat messages --content-type type=string
9 changes: 0 additions & 9 deletions e2e/campfire.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,6 @@ load test_helper
assert_output_contains "rich text"
}

@test "campfire --content-type visible on parent command for numeric-ID path" {
create_credentials
create_global_config '{"account_id": 99999}'

run basecamp campfire --help
assert_success
assert_output_contains "--content-type"
}

@test "campfire list help documents --all flag" {
create_credentials
create_global_config '{"account_id": 99999}'
Expand Down
4 changes: 2 additions & 2 deletions e2e/files.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,13 @@ load test_helper
assert_output_contains "Docs & Files"
}

@test "uploads routes to files command" {
@test "uploads command shows upload-specific help" {
create_credentials
create_global_config '{"account_id": 99999}'

run basecamp uploads --help
assert_success
assert_output_contains "Docs & Files"
assert_output_contains "uploaded files"
}

@test "docs routes to files command" {
Expand Down
Loading
Loading