Conversation
github-actions
bot
added
commands
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e417e0e3a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a bin/ci entrypoint and introduces a “skill drift” CI check to keep skills/basecamp/SKILL.md aligned with the CLI surface snapshot, alongside docs updates and a couple lint-driven cleanups.
Changes:
- Add
bin/cias a single local CI gate entrypoint (exec make check). - Add
scripts/check-skill-drift.sh+.surface-skill-driftbaseline and wirecheck-skill-driftintomake check. - Update contributor/agent docs to standardize on
bin/ciand remove pre-existing dead code flagged by linters.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/check-skill-drift.sh | New drift checker cross-referencing SKILL command/flag mentions against .surface. |
| .surface-skill-drift | Baseline file for known, pre-existing skill drift mismatches. |
| Makefile | Adds check-skill-drift target and includes it in check; updates help output. |
| bin/ci | New wrapper script to run the full make check gate. |
| CONTRIBUTING.md | Reframes contributor workflow around bin/setup + bin/ci. |
| AGENTS.md | Updates agent guidance and testing loop to emphasize bin/ci + skill drift checks. |
| internal/commands/todolists.go | Removes dead assignments flagged by ineffassign. |
| internal/commands/edit_test.go | Removes unused helper flagged by unused. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Simple script that delegates to make check. Matches Rails bin/ convention and gives contributors a single command to run before pushing. Update AGENTS.md and CONTRIBUTING.md to lead with bin/ci as the standard development loop — run early and often, not just before push.
Cross-references SKILL.md against the .surface snapshot to catch stale command and flag references. Extracts every basecamp invocation from the skill, resolves to the longest matching CMD, then verifies each --flag exists on that command or its subcommands. Pre-existing drift (mostly --in vs --project mismatches) is baselined in .surface-skill-drift so the check passes today and catches new drift going forward.
- Reject fallback to bare "basecamp" in resolve_cmd — if none of the candidate's subcommand tokens match a CMD, report as drift instead of silently accepting the root match (Codex P1) - Replace declare -A with grep -qxF for baseline lookups — avoids Bash 4+ requirement on stock macOS (Copilot) - Use BASH_REMATCH instead of grep|head -1 for command extraction — avoids SIGPIPE under pipefail (Copilot) - Strip YAML frontmatter before checking — trigger keywords like "basecamp project" are natural-language match phrases, not CLI commands
Remove dead vaultTitle assignment in files.go (ineffassign from main). Add 3 new pre-existing drift entries to baseline (--subject, --url, --question flags renamed/removed upstream).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
bin/ci— single entry point for the full CI gate (make check), matching Railsbin/conventionSKILL.mdagainst.surfaceto catch stale command/flag references; wired intomake checkbin/cias the standard development loopineffassignandunusedlintersTest plan
bin/cirunsmake checkand exits with the same codemake check-skill-driftpasses (14 pre-existing items baselined)Summary by cubic
Adds
bin/cias the single local CI entry point and adds a skill drift check that verifiesskills/basecamp/SKILL.mdagainst the CLI.surfaceto catch stale commands and flags. Docs instruct contributors to usebin/cias the standard loop.New Features
bin/cithat runsmake check;Makefilewirescheck-skill-driftintocheckandhelp.scripts/check-skill-drift.shwith a baseline of 17 known mismatches in.surface-skill-drift; fails on new drift.basecampfallback, uses grep-based baseline lookups (macOS Bash 3), usesBASH_REMATCH, and strips YAML frontmatter.AGENTS.mdandCONTRIBUTING.mdto center development onbin/ci.Refactors
vaultTitleassignment ininternal/commands/files.goflagged by linters.Written for commit 7c8f4ad. Summary will update on new commits.