Skip to content

Fix install script version detection on Windows #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 5 commits into from
Mar 9, 2026
Merged

Fix install script version detection on Windows #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7692d97
Fix version detection in install.sh for Windows compatibility
jeremy Mar 9, 2026
f350127
Fix version detection in ensure-basecamp.sh for Windows compatibility
jeremy Mar 9, 2026
c50e247
Guard curl failure in install.sh so friendly error message surfaces
jeremy Mar 9, 2026
16d5d84
Fix duplicate local and guard curl failure in ensure-basecamp.sh
jeremy Mar 9, 2026
6440e8d
Use semver format check for version guard in install scripts
jeremy Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/ensure-basecamp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,11 @@ install_basecamp() {
# Get platform
platform=$(detect_platform) || return 1

# Get latest version
version=$(curl -fsSL "https://api.github.com/repos/basecamp/basecamp-cli/releases/latest" 2>/dev/null | grep '"tag_name"' | sed -E 's/.*"v?([^"]+)".*/\1/')
if [[ -z "$version" ]]; then
# Get latest version via redirect (avoids GitHub API rate limits and grep/sed on Windows)
url=$(curl -fsSL -o /dev/null -w '%{url_effective}' "https://github.com/basecamp/basecamp-cli/releases/latest" 2>/dev/null) || true
version="${url##*/}"
version="${version#v}"
if [[ ! $version =~ ^[0-9]+\.[0-9]+ ]]; then
Comment thread
jeremy marked this conversation as resolved.
echo "Could not determine latest version" >&2
return 1
fi
Expand Down
10 changes: 7 additions & 3 deletions scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,13 @@ detect_platform() {
}

get_latest_version() {
local version
version=$(curl -fsSL "https://api.github.com/repos/${REPO}/releases/latest" 2>/dev/null | grep '"tag_name"' | sed -E 's/.*"v?([^"]+)".*/\1/')
if [[ -z "$version" ]]; then
local url version
# Follow the releases/latest redirect to get the version from the final URL.
# Avoids the GitHub API (no rate limiting) and grep/sed (better Windows compat).
url=$(curl -fsSL -o /dev/null -w '%{url_effective}' "https://github.com/${REPO}/releases/latest" 2>/dev/null) || true
Comment thread
jeremy marked this conversation as resolved.
version="${url##*/}"
version="${version#v}"
if [[ ! $version =~ ^[0-9]+\.[0-9]+ ]]; then
Comment thread
jeremy marked this conversation as resolved.
error "Could not determine latest version. Check your network connection."
fi
echo "$version"
Expand Down
Loading