Harden builds, polish releases, add plugin agents and docs#199
Merged
Conversation
jeremy
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a083bb6fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
github-actions
bot
added
enhancement
Add -trimpath to BUILD_FLAGS and goreleaser flags to strip absolute source paths from binaries. Set CGO_ENABLED=0 on local build targets to match release artifacts. Add test-release target for local goreleaser dry-runs. Add completions field to homebrew cask config so brew install auto-installs shell completions.
Surface test now distinguishes removals (always hard fail) from additions (soft fail, accepted with -update-surface). Add import ordering and testing conventions to STYLE.md.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Narrow baseline creation to os.ErrNotExist (not any ReadFile error). Fix module path in STYLE.md import ordering section. Clarify test-release comment: notarize disabled via empty env vars, not --skip flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-trimpathandCGO_ENABLED=0for local builds matching release artifacts;make test-releasefor local goreleaser dry-runs; Homebrew caskcompletions:field for auto-installed shell completions-update-surfaceaccepts)Test plan
make buildproduces binary withCGO_ENABLED=0and-trimpath=true(go version -m)! strings ./bin/basecamp | grep -Fq "$(pwd)")goreleaser checkvalidates configgo test ./internal/commands/ -run TestSurfaceSnapshotpasses