Skip to content

Conversation

@AdamK222
Copy link
Contributor

What changed? Why?
Submitting once again
Notes to reviewers
To check Base connection you need to connect your wallet first. To do this, you click on the "Connect Wallet" button and approve the connection. Then button shows up that allows to immediately switch your blockchain to Base if your wallet is by default connected to another chain.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 14, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns
Copy link
Contributor

wbnns commented Jan 15, 2025

Heya @AdamK222 , thanks for opening a new PR. Left one nit in-line but otherwise this should be good to go if you can update and fix the merge conflict. 🙏

@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related labels Jan 15, 2025
@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 2:38am

@vercel
Copy link

vercel bot commented Jan 15, 2025

@AdamK222 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@AdamK222
Copy link
Contributor Author

Hi, changed the description and resolved conflict, let me know if it's alright now

@AdamK222
Copy link
Contributor Author

I wanted to follow up. Is everything ok now with the pull request?

Copy link
Contributor

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamK222 Thanks for building on Base 🔵

@wbnns wbnns removed the change(s) requested One or more changes have been requested label Jan 26, 2025
@AdamK222
Copy link
Contributor Author

Can you merge? @wbnns

@AdamK222
Copy link
Contributor Author

AdamK222 commented Feb 7, 2025

Thank you so much!

@wbnns wbnns enabled auto-merge (squash) March 5, 2025 00:00
@wbnns wbnns merged commit 60d2822 into base:master Mar 5, 2025
6 of 7 checks passed
ARYZEofficial pushed a commit to ARYZEofficial/base-web that referenced this pull request Mar 7, 2025
* Update ecosystem.json

* Add files via upload

* Update ecosystem.json

* Update ecosystem.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base ecosystem review This is ecosystem related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants