fix(reth_entrypoint): add flashblocks to additional args instead of rewritting#646
Merged
haardikk21 merged 1 commit intobase:mainfrom Dec 22, 2025
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
mur-me
changed the title
Contributor
|
This seems good. Could you rebase? |
…ewritting, add explicit echo for additional arguments
mur-me
force-pushed
the
fix-reth-entrypoint-additional-args
branch
from
5e4a48a to
6cff9fc
Compare
Contributor
Author
Done, thanks |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
Hey @haardikk21 let's merge it if everything okay or it will closed by your github CI actions 🌝 |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
haardikk21
approved these changes
Dec 22, 2025
|
Bulliah |
sabbir00900900
approved these changes
Dec 29, 2025
|
node is good work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I found an issue with additional args in reth entrypoint, one of my args want propagate to the reth.
I've checked the code and found the root cause,
ADDITIONAL_ARGS="--websocket-url=$RETH_FB_WEBSOCKET_URL"is completely rewriting the ADDITIONAL_ARGS value.Funny, that pruning agrs don't have this issue
What was done: