Switch to git clone for geth versioning #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
commented
Aug 24, 2023
| cd op-node && \ | ||
| RUN git clone $REPO --branch op-node/$VERSION --single-branch . && \ | ||
| git switch -c branch-$VERSION && \ | ||
| bash -c '[ "$(git rev-parse HEAD)" = "$COMMIT" ]' |
There was a problem hiding this comment.
we could potentially leave this as is, but i prefer the consistency, and op-node may switch to dynamic versioning based on tags in the future
roberto-bayardo
approved these changes
Aug 24, 2023
|
Review Error for roberto-bayardo @ 2023-08-24 23:07:33 UTC |
roberto-bayardo
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
#54 switched to downloading tar.gz files from Github. Unfortunately this strips the .git information from the download, which breaks go-ethereum's
build/ci.goability to read commit and tag information.