Skip to content

Conversation

fan-zhang-sv
Copy link
Collaborator

Summary

  • added wallet_sign test cases in playground

Base Pay (712 Typed Data) Old Spec

Screenshot 2025-10-02 at 3 26 18 PM

Base Pay (712 Typed Data) New Spec - Nested under request

Screenshot 2025-10-02 at 3 26 30 PM

Personal Sign Old Spec

Screenshot 2025-10-02 at 3 26 01 PM

Personal Sign New Spec - Nested under request

Screenshot 2025-10-02 at 3 26 42 PM

How did you test your changes?

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 2, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for spencerstock @ 2025-10-03 16:32:10 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@fan-zhang-sv fan-zhang-sv merged commit ea2654d into master Oct 3, 2025
9 checks passed
@fan-zhang-sv fan-zhang-sv deleted the felix/wallet_sign branch October 3, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants