Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set winding order depending on first polygon #31

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Set winding order depending on first polygon #31

merged 2 commits into from
Jan 13, 2025

Conversation

magnusuMET
Copy link
Contributor

@magnusuMET magnusuMET commented Jan 8, 2025 •
edited
Loading

matplotlib seems to emit polygons in the reverse order in some cases. We now detect this and use the orientation of the first polygon encountered as the ring orientation.

This can occur if lats or lons are flipped

jgriesfeller
jgriesfeller approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@jgriesfeller jgriesfeller merged commit b54cdb7 into bartromgens:master Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgriesfeller jgriesfeller jgriesfeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusuMET @jgriesfeller