fixes crash when using contourf with extend option and changing contourf levels to represent a range. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzahasan
changed the title
|
@nzahasan Thanks for the fix. I just created a new release (v0.4.0) that contains it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using contourf_to_geojson_overlap with extend="both" in matplotlib contourf causes crash because this creates n+1 contour levels thus for last polygon no level existes in countourf.levels list. Also in case of coutourf plot the colors represent range. According to matplotlib documentation if defined levels are [1,5] then this will produce one filled contour with 1<fill_color <=5 level. If used with extend="max" the contour levels will be <=1, >1 to <=5, >5. This pull request tries to fix this issue.