Fix for bartromgens/geojsoncontour issue#10 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contourf_to_geojson(), every element of `contourf.collections` is
converted into a single GeoJSON MultiPolygon. While doing so every
matplotlib path object is converted into a separate GeoJSON Polygon
object. Before this fix, the result of `contourf_to_geojson()` was
a single GeoJSON Polygon (wrapped into a MultiPolygon) per GeoJSON Feature
made up of all the rings (LineStrings) of all Polygons (i.e. such a polygon
could have - in violation of the GeoJSON spec - multiple exterior rings).
The changes in the tests/benchmark_multipolycontourf.geojson file are
best displayed by the following command:
git diff --word-diff-regex=. tests/benchmark_multipolycontourf.geojson
1 similar comment
Closed
bartromgens
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Great! Looks good. Thanks.
Both multiple polygons per level, and polygon with hole render as expected by http://geojson.io and http://geojson.tools/ now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
contourf_to_geojson(), every element ofcontourf.collectionsis converted into a single GeoJSONMultiPolygon. While doing so everymatplotlibpath object is converted into a separate GeoJSONPolygonobject. Before this fix, the result ofcontourf_to_geojson()was a single GeoJSONPolygon(wrapped into aMultiPolygon) per GeoJSONFeaturemade up of all the rings (LineStrings) of allPolygons (i.e. such a polygon could have - in violation of the GeoJSON spec - multiple exterior rings).The changes in the
tests/benchmark_multipolycontourf.geojsonfile are best displayed by the following command: