Update expo example #101
Merged
Update expo example #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusl
reviewed
Nov 21, 2017
| @@ -71,15 +68,16 @@ export default class ProgressChart extends React.Component { | |||
| backgroundWidth={5} | |||
| fill={fill} | |||
| tintColor="#00e0ff" | |||
| onAnimationComplete={() => console.log('onAnimationComplete')} | |||
There was a problem hiding this comment.
I'd like to keep this as part of example since it is useful to see that the feature actually works while running the app
There was a problem hiding this comment.
Cool with me 👍 Any other thoughts?
markusl
reviewed
Nov 21, 2017
example/app.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "expo": { | |||
| "sdkVersion": "22.0.0" | |||
There was a problem hiding this comment.
The latest version seems to be 23
|
Looking good! If you could rebase on the latest master and fix the comments it can be merged |
|
Done - I'll let you merge. |
markusl
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes the old expo example and moves the code to a newly initialised expo example folder,
example, which is already covered in.npmignore. Testing and launching is now as easy as cloning and runningyarn start- no need to install expo globally.This move does not require a minor version bump, a patch will suffice.
Awaiting approval from @markusl