Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor presence roles into plugins #1698

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

bartfeenstra
Copy link
Owner

This fixes #1664

@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code labels Jul 11, 2024
@bartfeenstra bartfeenstra added this to the 0.4.x milestone Jul 11, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review July 11, 2024 22:26
@bartfeenstra bartfeenstra merged commit 470b933 into 0.4.x Jul 11, 2024
5 checks passed
@bartfeenstra bartfeenstra deleted the presence-role-plugins branch July 11, 2024 22:35
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 99.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.36%. Comparing base (ba5247f) to head (3020e24).
Report is 318 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/model/presence_role.py 98.63% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #1698      +/-   ##
==========================================
+ Coverage   95.34%   95.36%   +0.01%     
==========================================
  Files         212      213       +1     
  Lines       17271    17291      +20     
  Branches     3617     3611       -6     
==========================================
+ Hits        16467    16489      +22     
+ Misses        594      592       -2     
  Partials      210      210              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor presence roles to plugins
1 participant