Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure favicon.ico always exists (to satisfy eager clients) #1598

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1404

@bartfeenstra bartfeenstra added the enhancement New feature or request label Jun 21, 2024
@bartfeenstra bartfeenstra changed the base branch from 0.4.x to 0.3.x June 21, 2024 21:08
@bartfeenstra bartfeenstra marked this pull request as ready for review June 21, 2024 21:08
Copy link

Uploaded Betty for commit 9583c0d. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit 988bd75 into 0.3.x Jun 21, 2024
9 checks passed
@bartfeenstra bartfeenstra deleted the favicon-0.3.x branch June 24, 2024 14:44
@bartfeenstra bartfeenstra added this to the 0.3.x milestone Jul 29, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (4f4e092) to head (9583c0d).
Report is 25 commits behind head on 0.3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1598      +/-   ##
==========================================
+ Coverage   95.52%   95.62%   +0.10%     
==========================================
  Files         199      198       -1     
  Lines       19181    18986     -195     
  Branches     3659     3608      -51     
==========================================
- Hits        18322    18156     -166     
+ Misses        590      566      -24     
+ Partials      269      264       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename betty.ico to favicon.ico
1 participant