Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Configuration.load() an instance method #1512

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Make Configuration.load() an instance method #1512

merged 1 commit into from
Jun 26, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1372

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels May 19, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone May 19, 2024
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit f8812f4. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the configuration-load-instance-method branch from f8812f4 to b400c8a Compare June 21, 2024 17:47
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit b400c8a. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the configuration-load-instance-method branch from b400c8a to 43da47a Compare June 21, 2024 20:46
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit 43da47a. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the configuration-load-instance-method branch from 43da47a to e5a84b1 Compare June 21, 2024 23:42
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit e5a84b1. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra changed the base branch from 0.3.x to 0.4.x June 22, 2024 00:07
@bartfeenstra bartfeenstra force-pushed the configuration-load-instance-method branch from e5a84b1 to ff983a7 Compare June 22, 2024 12:23
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit ff983a7. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@github-actions GitHub Actions
Copy link

Uploaded Betty for commit 8d60aff. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

bartfeenstra
bartfeenstra commented Jun 25, 2024
View reviewed changes
betty/config.py Outdated Show resolved Hide resolved
bartfeenstra
bartfeenstra commented Jun 25, 2024
View reviewed changes
betty/config.py Outdated Show resolved Hide resolved
@bartfeenstra bartfeenstra force-pushed the configuration-load-instance-method branch 2 times, most recently from e5d7e1c to 342c98c Compare June 26, 2024 11:03
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit e5d7e1c. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@github-actions GitHub Actions
Copy link

Uploaded Betty for commit 342c98c. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

bartfeenstra
bartfeenstra commented Jun 26, 2024
View reviewed changes
betty/config.py Outdated Show resolved Hide resolved
@bartfeenstra bartfeenstra force-pushed the configuration-load-instance-method branch 3 times, most recently from 018f729 to 15faccb Compare June 26, 2024 17:46
@bartfeenstra bartfeenstra marked this pull request as ready for review June 26, 2024 17:47
@bartfeenstra bartfeenstra force-pushed the configuration-load-instance-method branch from 15faccb to baf0a0a Compare June 26, 2024 17:58
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.65013% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.90%. Comparing base (bc15a29) to head (baf0a0a).
Report is 310 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/config.py 85.71% 2 Missing and 2 partials ⚠️
betty/tests/test_config.py 94.11% 4 Missing ⚠️
betty/project.py 97.61% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            0.4.x    #1512      +/-   ##
==========================================
+ Coverage   95.73%   95.90%   +0.16%     
==========================================
  Files         200      200              
  Lines       18750    18883     +133     
  Branches     3556     3516      -40     
==========================================
+ Hits        17950    18109     +159     
+ Misses        540      524      -16     
+ Partials      260      250      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit f089858 into 0.4.x Jun 26, 2024
10 of 11 checks passed
@bartfeenstra bartfeenstra deleted the configuration-load-instance-method branch June 26, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
0.4.x
Development

Successfully merging this pull request may close these issues.

Make betty.config.Configuration.load() an instance method
1 participant
@bartfeenstra